Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 24182005: Fix partial swap support (Closed)

Created:
7 years, 3 months ago by jbauman
Modified:
7 years, 3 months ago
Reviewers:
danakj1, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, apatrick_chromium, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

Fix partial swap support This was accidentally disabled. BUG=292900 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223602

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M content/common/gpu/client/context_provider_command_buffer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jbauman
7 years, 3 months ago (2013-09-17 00:50:47 UTC) #1
piman
lgtm
7 years, 3 months ago (2013-09-17 03:12:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/24182005/1
7 years, 3 months ago (2013-09-17 03:57:02 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=198222
7 years, 3 months ago (2013-09-17 06:12:36 UTC) #4
danakj
On 2013/09/17 06:12:36, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 3 months ago (2013-09-17 06:18:53 UTC) #5
jbauman
On 2013/09/17 06:18:53, danakj wrote: > On 2013/09/17 06:12:36, I haz the power (commit-bot) wrote: ...
7 years, 3 months ago (2013-09-17 06:45:18 UTC) #6
jbauman
On 2013/09/17 06:45:18, jbauman wrote: > On 2013/09/17 06:18:53, danakj wrote: > > On 2013/09/17 ...
7 years, 3 months ago (2013-09-17 06:57:47 UTC) #7
piman
lgtm
7 years, 3 months ago (2013-09-17 07:14:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/24182005/31001
7 years, 3 months ago (2013-09-17 07:20:42 UTC) #9
commit-bot: I haz the power
Change committed as 223602
7 years, 3 months ago (2013-09-17 13:13:46 UTC) #10
danakj1
7 years, 3 months ago (2013-09-17 14:25:45 UTC) #11
On Mon, Sep 16, 2013 at 11:57 PM, <jbauman@chromium.org> wrote:

> On 2013/09/17 06:45:18, jbauman wrote:
>
>> On 2013/09/17 06:18:53, danakj wrote:
>> > On 2013/09/17 06:12:36, I haz the power (commit-bot) wrote:
>> > > Retried try job too often on win_rel for step(s) browser_tests
>> > >
>> >
>>
>
> http://build.chromium.org/p/**tryserver.chromium/**
>
buildstatus?builder=win_rel&**number=198222<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=198222>
>
>> >
>> > What about the in process context?
>>
>
>  Hmm, it seems weird that all the other options there are hard-coded,
>> whereas
>>
> we
>
>> can't hard-code this. However, I guess I can add it.
>>
>
> Ok, added support for the in-process context.
>

Thanks :)  I think we'll have to add more dynamic checking there over time.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698