Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 24182003: Take 2 at removing thumb thickness compositor setting. (Closed)

Created:
7 years, 3 months ago by tony
Modified:
7 years, 3 months ago
CC:
chromium-reviews, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Take 2 at removing thumb thickness compositor setting. Instead, we get the value from blink (landed in blink r157790). No change in behavior on Android or Desktop. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223558

Patch Set 1 #

Patch Set 2 : remove spurious change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M cc/layers/scrollbar_layer_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tony
7 years, 3 months ago (2013-09-16 19:31:09 UTC) #1
wjmaclean
On 2013/09/16 19:31:09, tony wrote: This looks good to me.
7 years, 3 months ago (2013-09-16 19:52:45 UTC) #2
jamesr
lgtm
7 years, 3 months ago (2013-09-16 20:05:08 UTC) #3
aelias_OOO_until_Jul13
lgtm
7 years, 3 months ago (2013-09-16 20:07:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/24182003/1007
7 years, 3 months ago (2013-09-16 20:21:16 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=198058
7 years, 3 months ago (2013-09-17 00:24:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/24182003/1007
7 years, 3 months ago (2013-09-17 02:21:52 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 06:59:57 UTC) #8
Message was sent while issue was closed.
Change committed as 223558

Powered by Google App Engine
This is Rietveld 408576698