Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2418143004: Reduce FOR_EACH_OBSERVER usage in content/browser/renderer_host (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
clamy, tdresser, boliu
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce FOR_EACH_OBSERVER usage in content/browser/renderer_host Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/de3863410bd8a5d13537e0206f1630d5e36b295b Cr-Commit-Position: refs/heads/master@{#426120}

Patch Set 1 #

Patch Set 2 : three had been missed #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -215 lines) Patch
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 6 chunks +16 lines, -18 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/text_input_manager.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 58 chunks +166 lines, -175 lines 0 comments Download

Messages

Total messages: 31 (20 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 12:55:12 UTC) #6
Eric Willigers
4 years, 2 months ago (2016-10-17 22:27:08 UTC) #12
Eric Willigers
4 years, 2 months ago (2016-10-18 01:52:41 UTC) #14
boliu
what do you want each reviewer to review?
4 years, 2 months ago (2016-10-18 03:28:56 UTC) #15
Eric Willigers
On 2016/10/18 03:28:56, boliu wrote: > what do you want each reviewer to review? If ...
4 years, 2 months ago (2016-10-18 04:12:08 UTC) #16
boliu
lgtm
4 years, 2 months ago (2016-10-18 04:59:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418143004/20001
4 years, 2 months ago (2016-10-18 05:13:09 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/88447) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-10-18 05:15:59 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418143004/40001
4 years, 2 months ago (2016-10-19 02:02:05 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-19 02:35:33 UTC) #29
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:05:55 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/de3863410bd8a5d13537e0206f1630d5e36b295b
Cr-Commit-Position: refs/heads/master@{#426120}

Powered by Google App Engine
This is Rietveld 408576698