Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24181004: Remove LogInterfaces (Closed)

Created:
7 years, 3 months ago by Noam Samuel
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove LogInterfaces In debug builds, LogInterfaces cannot run in the IO or the UI threads due to an AssertIOAllowed() call (seems the IO thread cannot run actual IO either, see https://code.google.com/p/chromium/codesearch#chromium/src/base/threading/thread_restrictions.h ) NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223473

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M chrome/browser/local_discovery/service_discovery_host_client.cc View 3 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Noam Samuel
7 years, 3 months ago (2013-09-16 22:47:03 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 3 months ago (2013-09-16 23:31:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/24181004/13001
7 years, 3 months ago (2013-09-16 23:34:17 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 23:35:52 UTC) #4
Message was sent while issue was closed. 
Change committed as 223473

Powered by Google App Engine
This is Rietveld 408576698