Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: content/shell/browser/shell.h

Issue 2417983002: Form submissions opening in a new window don't need special treatment anymore. (Closed)
Patch Set: Using params.source_site_instance for consistency with //chrome layer. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/shell/browser/shell.cc » ('j') | content/shell/browser/shell.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/shell.h
diff --git a/content/shell/browser/shell.h b/content/shell/browser/shell.h
index 708b3d572e1ca5b285c9dad78f5113e56b9a9700..4068230fb90dd0c7508ce59d894dc5b01dc0598f 100644
--- a/content/shell/browser/shell.h
+++ b/content/shell/browser/shell.h
@@ -10,6 +10,7 @@
#include <vector>
#include "base/callback_forward.h"
+#include "base/memory/ref_counted.h"
#include "base/strings/string_piece.h"
#include "build/build_config.h"
#include "content/public/browser/web_contents_delegate.h"
@@ -85,10 +86,11 @@ class Shell : public WebContentsDelegate,
// Do one time initialization at application startup.
static void Initialize();
- static Shell* CreateNewWindow(BrowserContext* browser_context,
- const GURL& url,
- SiteInstance* site_instance,
- const gfx::Size& initial_size);
+ static Shell* CreateNewWindow(
+ BrowserContext* browser_context,
+ const GURL& url,
+ const scoped_refptr<SiteInstance>& site_instance,
Łukasz Anforowicz 2016/10/20 22:56:42 scoped_refptr is better than a raw pointer, right?
+ const gfx::Size& initial_size);
// Returns the Shell object corresponding to the given RenderViewHost.
static Shell* FromRenderViewHost(RenderViewHost* rvh);
« no previous file with comments | « no previous file | content/shell/browser/shell.cc » ('j') | content/shell/browser/shell.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698