Form submissions opening in a new window don't need special treatment anymore.

content/shell/browser/shell.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/browser/shell.h"
 
 #include <stddef.h>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 158 matching lines @@
 }
 
 gfx::Size Shell::AdjustWindowSize(const gfx::Size& initial_size) {
   if (!initial_size.IsEmpty())
     return initial_size;
   return GetShellDefaultSize();
 }
 
 Shell* Shell::CreateNewWindow(BrowserContext* browser_context,
                               const GURL& url,
-                              SiteInstance* site_instance,
+                              const scoped_refptr<SiteInstance>& site_instance,
                               const gfx::Size& initial_size) {
   WebContents::CreateParams create_params(browser_context, site_instance);
   create_params.initial_size = AdjustWindowSize(initial_size);
   WebContents* web_contents = WebContents::Create(create_params);
   Shell* shell = CreateShell(web_contents, create_params.initial_size);
   if (!url.is_empty())
     shell->LoadURL(url);
   return shell;
 }
 
@@ skipping 115 matching lines @@
 }
 
 gfx::NativeView Shell::GetContentView() {
   if (!web_contents_)
     return NULL;
   return web_contents_->GetNativeView();
 }
 
 WebContents* Shell::OpenURLFromTab(WebContents* source,
                                    const OpenURLParams& params) {
-  // This implementation only handles CURRENT_TAB.
-  if (params.disposition != WindowOpenDisposition::CURRENT_TAB)
-    return nullptr;
+  WebContents* target = nullptr;
+  switch (params.disposition) {
+    case WindowOpenDisposition::CURRENT_TAB:
+      target = source;
+      break;
+
+    // Normally, the difference between NEW_POPUP and NEW_WINDOW is that a popup
+    // should have no toolbar, no status bar, no menu bar, no scrollbars and be
+    // not resizable.  For simplicity and to enable new testing scenarios in
+    // content shell and layout tests, popups don't get special treatment below
+    // (i.e. they will have a toolbar and other things described here).
+    case WindowOpenDisposition::NEW_POPUP:
+    case WindowOpenDisposition::NEW_WINDOW: {
+      Shell* new_window =
+          Shell::CreateNewWindow(source->GetBrowserContext(),
+                                 GURL(),  // Don't load anything just yet.
+                                 params.source_site_instance,

[Łukasz Anforowicz, 2016/10/20 22:56:42]

Using |params.source_site_instance| is consistent with //chrome layer and
therefore seems better to me than using |source->GetSiteInstance()| (even if
they happen to be the same here).

[nasko, 2016/10/21 16:32:47]

Acknowledged.

+                                 gfx::Size());  // Use default size.
+      target = new_window->web_contents();
+      if (switches::IsRunLayoutTestSwitchPresent())
+        SecondaryTestWindowObserver::CreateForWebContents(target);
+      break;
+    }
+
+    // No tabs in content_shell:
+    case WindowOpenDisposition::SINGLETON_TAB:
+    case WindowOpenDisposition::NEW_FOREGROUND_TAB:
+    case WindowOpenDisposition::NEW_BACKGROUND_TAB:
+    // No incognito mode in content_shell:
+    case WindowOpenDisposition::OFF_THE_RECORD:
+    // TODO(lukasza): Investigate if some layout tests might need support for
+    // SAVE_TO_DISK disposition.  This would probably require that
+    // BlinkTestController always sets up and cleans up a temporary directory
+    // as the default downloads destinations for the duration of a test.
+    case WindowOpenDisposition::SAVE_TO_DISK:
+    // Ignoring requests with disposition == IGNORE_ACTION...
+    case WindowOpenDisposition::IGNORE_ACTION:
+    default:
+      return nullptr;
+  }
 
   NavigationController::LoadURLParams load_url_params(params.url);
   load_url_params.source_site_instance = params.source_site_instance;
   load_url_params.transition_type = params.transition;
   load_url_params.frame_tree_node_id = params.frame_tree_node_id;
   load_url_params.referrer = params.referrer;
   load_url_params.redirect_chain = params.redirect_chain;
   load_url_params.extra_headers = params.extra_headers;
   load_url_params.is_renderer_initiated = params.is_renderer_initiated;
   load_url_params.should_replace_current_entry =
       params.should_replace_current_entry;
 
   if (params.uses_post) {
     load_url_params.load_type = NavigationController::LOAD_TYPE_HTTP_POST;
     load_url_params.post_data = params.post_data;
   }
 
-  source->GetController().LoadURLWithParams(load_url_params);
-  return source;
+  target->GetController().LoadURLWithParams(load_url_params);
+  return target;
 }
 
 void Shell::LoadingStateChanged(WebContents* source,
     bool to_different_document) {
   UpdateNavigationControls(to_different_document);
   PlatformSetIsLoading(source->IsLoading());
 }
 
 void Shell::EnterFullscreenModeForTab(WebContents* web_contents,
                                       const GURL& origin) {
@@ skipping 115 matching lines @@
   if (entry)
     PlatformSetTitle(entry->GetTitle());
 }
 
 void Shell::OnDevToolsWebContentsDestroyed() {
   devtools_observer_.reset();
   devtools_frontend_ = NULL;
 }
 
 }  // namespace content