Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: remoting/signaling/iq_sender.cc

Issue 2417913002: Process incoming IQs in the same order that they were sent. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/signaling/fake_signal_strategy.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/signaling/iq_sender.cc
diff --git a/remoting/signaling/iq_sender.cc b/remoting/signaling/iq_sender.cc
index aa40adfe973589d92823c3a295d7a92008733cf5..725cc08c68f4ccbc29d42c45a346dfe353bbbf0e 100644
--- a/remoting/signaling/iq_sender.cc
+++ b/remoting/signaling/iq_sender.cc
@@ -48,8 +48,11 @@ std::unique_ptr<IqRequest> IqSender::SendIq(
std::unique_ptr<buzz::XmlElement> stanza,
const ReplyCallback& callback) {
std::string addressee = stanza->Attr(buzz::QN_TO);
- std::string id = signal_strategy_->GetNextId();
- stanza->AddAttr(buzz::QN_ID, id);
+ std::string id = stanza->Attr(buzz::QN_ID);
+ if (id.empty()) {
+ id = signal_strategy_->GetNextId();
+ stanza->AddAttr(buzz::QN_ID, id);
+ }
if (!signal_strategy_->SendStanza(std::move(stanza))) {
return nullptr;
}
« no previous file with comments | « remoting/signaling/fake_signal_strategy.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698