Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1805)

Unified Diff: components/data_use_measurement/content/data_use_measurement.h

Issue 2417773005: Record the time since Chromium is in background for background data use (Closed)
Patch Set: Addressed holte comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/data_use_measurement/content/data_use_measurement.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_use_measurement/content/data_use_measurement.h
diff --git a/components/data_use_measurement/content/data_use_measurement.h b/components/data_use_measurement/content/data_use_measurement.h
index 3343b8fdb9849ba46492e99df934ff9be6491a49..777a50a3623196de1020e73a26db14d0e04d8f5a 100644
--- a/components/data_use_measurement/content/data_use_measurement.h
+++ b/components/data_use_measurement/content/data_use_measurement.h
@@ -12,6 +12,7 @@
#include "base/callback.h"
#include "base/macros.h"
+#include "base/time/time.h"
#include "build/build_config.h"
#include "components/data_use_measurement/core/data_use_user_data.h"
#include "components/metrics/data_use_tracker.h"
@@ -67,6 +68,8 @@ class DataUseMeasurement {
private:
friend class DataUseMeasurementTest;
+ FRIEND_TEST_ALL_PREFIXES(DataUseMeasurementTest,
+ TimeOfBackgroundDownstreamBytes);
// Specifies that data is received or sent, respectively.
enum TrafficDirection { DOWNSTREAM, UPSTREAM };
@@ -103,8 +106,8 @@ class DataUseMeasurement {
// |dir| is the direction (which is upstream or downstream) and |bytes| is the
// number of bytes in the direction.
void ReportDataUseUMA(const net::URLRequest& request,
- TrafficDirection dir,
- int64_t bytes) const;
+ TrafficDirection dir,
+ int64_t bytes);
// Updates the data use of the |request|, thus |request| must be non-null.
void UpdateDataUsePrefs(const net::URLRequest& request) const;
@@ -147,6 +150,13 @@ class DataUseMeasurement {
// delegate since the operating system was last queried for traffic
// statistics.
int64_t bytes_transferred_since_last_traffic_stats_query_;
+
+ // The time at which Chromium app state changed to background. Can be null if
+ // app is not in background.
+ base::TimeTicks last_app_background_time_;
+
+ // True if app is in background and first network read has not yet happened.
+ bool no_reads_since_background_;
#endif
DISALLOW_COPY_AND_ASSIGN(DataUseMeasurement);
« no previous file with comments | « no previous file | components/data_use_measurement/content/data_use_measurement.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698