Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 24177004: Exclude more files from the PRESUBMIT #include check. (Closed)

Created:
7 years, 3 months ago by marja
Modified:
7 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Exclude more files from the PRESUBMIT #include check. These files need to be included out-of-order. BUG=NONE NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224367

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M PRESUBMIT.py View 1 chunk +6 lines, -3 lines 0 comments Download
M PRESUBMIT_test.py View 1 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
maruel@, ptal
7 years, 3 months ago (2013-09-20 07:55:04 UTC) #1
M-A Ruel
lgtm
7 years, 3 months ago (2013-09-20 12:11:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/24177004/3001
7 years, 3 months ago (2013-09-20 12:15:29 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 12:16:34 UTC) #4
Message was sent while issue was closed.
Change committed as 224367

Powered by Google App Engine
This is Rietveld 408576698