Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: net/nqe/network_quality.h

Issue 2417643007: Expose RTT and throughput estimates from Cronet (Closed)
Patch Set: Removed annotation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_quality.h
diff --git a/net/nqe/network_quality.h b/net/nqe/network_quality.h
index 457c71e88878ec8f818a9578976730cf469d57f0..9a7dbe460c4cf71bb2a1af83eebb01aded5f9025 100644
--- a/net/nqe/network_quality.h
+++ b/net/nqe/network_quality.h
@@ -16,14 +16,26 @@ namespace net {
namespace nqe {
namespace internal {
+// RTT and throughput values are set to |INVALID_RTT_THROUGHPUT| if a valid
+// value is unavailable.
+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.net
+enum RttThroughputValues {
+ // Invalid value.
+ INVALID_RTT_THROUGHPUT = -1,
+};
+
// Returns the RTT value to be used when the valid RTT is unavailable. Readers
// should discard RTT if it is set to the value returned by |InvalidRTT()|.
+// TODO(tbansal): Remove this method, and replace all calls by
+// |INVALID_RTT_THROUGHPUT|.
NET_EXPORT_PRIVATE base::TimeDelta InvalidRTT();
// Throughput is set to |kInvalidThroughput| if a valid value is
// unavailable. Readers should discard throughput value if it is set to
// |kInvalidThroughput|.
-const int32_t kInvalidThroughput = 0;
+// TODO(tbansal): Remove this variable, and replace all calls by
+// |INVALID_RTT_THROUGHPUT|.
+const int32_t kInvalidThroughput = INVALID_RTT_THROUGHPUT;
// NetworkQuality is used to cache the quality of a network connection.
class NET_EXPORT_PRIVATE NetworkQuality {

Powered by Google App Engine
This is Rietveld 408576698