Move composited toolbar to bottom of screen when Chrome Home is enabled

Move composited toolbar to bottom of screen when Chrome Home is enabled

This change moves the composited toolbar to the bottom of the screen
but does not change the content offsets. This causes an empty
rectangle at the top of the screen.

BUG=652892
Committed: https://crrev.com/7c073e02e0736f48c1463d34326bffd71abb4490
Cr-Commit-Position: refs/heads/master@{#426867}

[mdjones, 2016-10-17 18:43:10]

mdjones@chromium.org changed reviewers:
+ twellington@chromium.org

[mdjones, 2016-10-17 18:43:11]

ptal

[Theresa, 2016-10-18 00:27:29]

Looks good overall.

https://codereview.chromium.org/2417323002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java
(right):

https://codereview.chromium.org/2417323002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java:77:
t.canUseLiveTexture(), FeatureUtilities.isChromeHomeEnabled(),
It might be worth making an equivalent switch in C++ for isChromeHomeEnabled()
to avoid passing this through JNI and plumbing through a few classes. We'll need
a native flag when we add this to about://flags too.

base::CommandLine::ForCurrentProcess()->HasSwitch(const char switch_constant[])

https://codereview.chromium.org/2417323002/diff/20001/chrome/browser/android/...
File chrome/browser/android/compositor/layer/toolbar_layer.cc (right):

https://codereview.chromium.org/2417323002/diff/20001/chrome/browser/android/...
chrome/browser/android/compositor/layer/toolbar_layer.cc:63:
resource->size.height() - resource->padding.size().height();
nit: move inside is_chrome_home_enabled block?

[mdjones, 2016-10-18 23:47:51]

https://codereview.chromium.org/2417323002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java
(right):

https://codereview.chromium.org/2417323002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java:77:
t.canUseLiveTexture(), FeatureUtilities.isChromeHomeEnabled(),
On 2016/10/18 00:27:29, Theresa Wellington wrote:
> It might be worth making an equivalent switch in C++ for isChromeHomeEnabled()
> to avoid passing this through JNI and plumbing through a few classes. We'll
need
> a native flag when we add this to about://flags too.
> 
> base::CommandLine::ForCurrentProcess()->HasSwitch(const char
switch_constant[])

Used the native feature api: base::FeatureList::IsEnabled(...);

https://codereview.chromium.org/2417323002/diff/20001/chrome/browser/android/...
File chrome/browser/android/compositor/layer/toolbar_layer.cc (right):

https://codereview.chromium.org/2417323002/diff/20001/chrome/browser/android/...
chrome/browser/android/compositor/layer/toolbar_layer.cc:63:
resource->size.height() - resource->padding.size().height();
On 2016/10/18 00:27:29, Theresa Wellington wrote:
> nit: move inside is_chrome_home_enabled block?

Done.

[Theresa, 2016-10-19 00:08:12]

lgtm

[mdjones, 2016-10-19 00:13:24]

Description was changed from

==========
Move composited toolbar to bottom of screen

This change moves the composited toolbar to the bottom of the screen
but does not change the content offsets. This causes an empty
rectangle at the top of the screen.

BUG=652892
==========

to

==========
Move composited toolbar to bottom of screen when Chrome Home is enabled

This change moves the composited toolbar to the bottom of the screen
but does not change the content offsets. This causes an empty
rectangle at the top of the screen.

BUG=652892
==========

[mdjones, 2016-10-19 00:13:55]

mdjones@chromium.org changed reviewers:
+ dtrainor@chromium.org

[mdjones, 2016-10-19 00:13:56]

+dtrainor for owners, ptal.

[David Trainor- moved to gerrit, 2016-10-21 16:11:51]

lgtm % your decision on nit.

https://codereview.chromium.org/2417323002/diff/60001/chrome/browser/android/...
File chrome/browser/android/compositor/layer/toolbar_layer.cc (right):

https://codereview.chromium.org/2417323002/diff/60001/chrome/browser/android/...
chrome/browser/android/compositor/layer/toolbar_layer.cc:196:
is_chrome_home_enabled_ =
Remove one of the newlines above?  Can we put this at teh top of the
constructor?  Almost feels like it should be set in the initializer list?

[mdjones, 2016-10-21 16:56:44]

https://codereview.chromium.org/2417323002/diff/60001/chrome/browser/android/...
File chrome/browser/android/compositor/layer/toolbar_layer.cc (right):

https://codereview.chromium.org/2417323002/diff/60001/chrome/browser/android/...
chrome/browser/android/compositor/layer/toolbar_layer.cc:196:
is_chrome_home_enabled_ =
On 2016/10/21 16:11:51, David Trainor wrote:
> Remove one of the newlines above?  Can we put this at teh top of the
> constructor?  Almost feels like it should be set in the initializer list?

Added to initializer list.

[mdjones, 2016-10-21 16:57:02]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-10-21 16:57:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2417323002/#ps80001
(title: "move flag to initializer list")

[commit-bot: I haz the power, 2016-10-21 16:57:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 19:52:43]

Description was changed from

==========
Move composited toolbar to bottom of screen when Chrome Home is enabled

This change moves the composited toolbar to the bottom of the screen
but does not change the content offsets. This causes an empty
rectangle at the top of the screen.

BUG=652892
==========

to

==========
Move composited toolbar to bottom of screen when Chrome Home is enabled

This change moves the composited toolbar to the bottom of the screen
but does not change the content offsets. This causes an empty
rectangle at the top of the screen.

BUG=652892
==========

[commit-bot: I haz the power, 2016-10-21 19:52:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-21 20:00:05]

Description was changed from

==========
Move composited toolbar to bottom of screen when Chrome Home is enabled

This change moves the composited toolbar to the bottom of the screen
but does not change the content offsets. This causes an empty
rectangle at the top of the screen.

BUG=652892
==========

to

==========
Move composited toolbar to bottom of screen when Chrome Home is enabled

This change moves the composited toolbar to the bottom of the screen
but does not change the content offsets. This causes an empty
rectangle at the top of the screen.

BUG=652892

Committed: https://crrev.com/7c073e02e0736f48c1463d34326bffd71abb4490
Cr-Commit-Position: refs/heads/master@{#426867}
==========

[commit-bot: I haz the power, 2016-10-21 20:00:06]

Patchset 5 (id:??) landed as
https://crrev.com/7c073e02e0736f48c1463d34326bffd71abb4490
Cr-Commit-Position: refs/heads/master@{#426867}