Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2417313002: About flag for doc.write to be tri-state so it can be disabled. (Closed)

Created:
4 years, 2 months ago by shivanisha
Modified:
4 years, 2 months ago
Reviewers:
Bryan McQuade
CC:
asvitkine+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

About flag for doc.write to be tri-state so it can be disabled. BUG=635743 Committed: https://crrev.com/a96778dfbbb5440baf247b80509a248689f26ef8 Cr-Commit-Position: refs/heads/master@{#426230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
shivanisha
PTAL, Thanks!
4 years, 2 months ago (2016-10-14 17:30:49 UTC) #3
Bryan McQuade
LGTM, thanks!
4 years, 2 months ago (2016-10-18 14:24:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417313002/1
4 years, 2 months ago (2016-10-18 14:54:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/316817)
4 years, 2 months ago (2016-10-18 16:02:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417313002/1
4 years, 2 months ago (2016-10-19 16:19:58 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 17:19:26 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:09:39 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a96778dfbbb5440baf247b80509a248689f26ef8
Cr-Commit-Position: refs/heads/master@{#426230}

Powered by Google App Engine
This is Rietveld 408576698