Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 24172008: Fix uploading binary files to rietveld. (Closed)

Created:
7 years, 3 months ago by chrisphan
Modified:
7 years, 3 months ago
Reviewers:
iannucci, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Fix uploading binary files to rietveld. httplib chokes on concatenating the unicode string "url" and some bytecode in "data". BUG=169600 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=225058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gcl.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
chrisphan
Moved CL from https://codereview.chromium.org/23533071/
7 years, 3 months ago (2013-09-20 23:17:24 UTC) #1
chrisphan
On 2013/09/20 23:17:24, chrisphan wrote: > Moved CL from https://codereview.chromium.org/23533071/ Is this good to go?
7 years, 3 months ago (2013-09-24 18:23:19 UTC) #2
M-A Ruel
lgtm
7 years, 3 months ago (2013-09-24 20:13:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisphan@chromium.org/24172008/1
7 years, 3 months ago (2013-09-24 20:14:09 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-24 20:16:21 UTC) #5
Message was sent while issue was closed.
Change committed as 225058

Powered by Google App Engine
This is Rietveld 408576698