Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1585)

Issue 2417183003: Remove stl_util's deletion functions from remaining quic code. (Closed)

Created:
4 years, 2 months ago by Avi (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's deletion functions from remaining quic code. Merge internal change: 136848647 BUG=555865 Committed: https://crrev.com/b363545135e9ac1f943cdfde25b0589acd722942 Cr-Commit-Position: refs/heads/master@{#426850}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -92 lines) Patch
M net/quic/chromium/crypto/channel_id_chromium.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/crypto/channel_id_chromium.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M net/quic/chromium/crypto/proof_verifier_chromium.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/chromium/crypto/proof_verifier_chromium.cc View 4 chunks +17 lines, -15 lines 0 comments Download
M net/quic/chromium/quic_end_to_end_unittest.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 6 chunks +11 lines, -16 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/core/crypto/crypto_server_config_protobuf.h View 4 chunks +7 lines, -6 lines 0 comments Download
M net/quic/core/crypto/crypto_server_config_protobuf.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager_test.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M net/quic/core/quic_unacked_packet_map_test.cc View 3 chunks +1 line, -3 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M net/tools/quic/quic_client_session.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 2 chunks +1 line, -3 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 6 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Avi (use Gerrit)
4 years, 2 months ago (2016-10-20 23:04:19 UTC) #9
Zhongyi Shi
lgtm! BTW, what's the status of this series of cls? Do we have any more ...
4 years, 1 month ago (2016-10-21 17:12:01 UTC) #12
Avi (use Gerrit)
On 2016/10/21 17:12:01, Zhongyi Shi wrote: > lgtm! > > BTW, what's the status of ...
4 years, 1 month ago (2016-10-21 17:20:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417183003/20001
4 years, 1 month ago (2016-10-21 17:59:32 UTC) #16
Zhongyi Shi
On 2016/10/21 17:20:59, Avi wrote: > On 2016/10/21 17:12:01, Zhongyi Shi wrote: > > lgtm! ...
4 years, 1 month ago (2016-10-21 18:16:28 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-21 18:34:18 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-10-21 18:42:49 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b363545135e9ac1f943cdfde25b0589acd722942
Cr-Commit-Position: refs/heads/master@{#426850}

Powered by Google App Engine
This is Rietveld 408576698