Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_box.cc

Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal… (Closed)
Patch Set: address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_box.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_box.cc b/third_party/WebKit/Source/core/layout/ng/ng_box.cc
index e7a4f4e64da8a127601800b7d962de0ae095035f..cf75f73f7fc365a98bbef36a123ce01eb34e7db1 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_box.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_box.cc
@@ -15,13 +15,6 @@
#include "core/layout/ng/ng_writing_mode.h"
namespace blink {
-namespace {
-// TODO(layout-ng): Add m_isNewFc flag to ComputedStyle and set it from
-// StyleResolver instead of getting it calculated by createsNewFormattingContext
-bool IsNewFormattingContext(const LayoutBox* layout_box) {
- return layout_box && toLayoutBlock(layout_box)->createsNewFormattingContext();
-}
-} // namespace
NGBox::NGBox(LayoutObject* layout_object)
: layout_box_(toLayoutBox(layout_object)) {
@@ -46,8 +39,6 @@ bool NGBox::Layout(const NGConstraintSpace* constraint_space,
NGConstraintSpace* child_constraint_space = new NGConstraintSpace(
FromPlatformWritingMode(Style()->getWritingMode()),
FromPlatformDirection(Style()->direction()), constraint_space);
- child_constraint_space->SetIsNewFormattingContext(
- IsNewFormattingContext(layout_box_));
NGPhysicalFragment* fragment = nullptr;
if (!algorithm_->Layout(child_constraint_space, &fragment))

Powered by Google App Engine
This is Rietveld 408576698