Issue 24170002: Allow tab permission to be granted for chrome:// pages through activeTab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24170002: Allow tab permission to be granted for chrome:// pages through activeTab. (Closed)

Created:
7 years, 3 months ago by justinlin

Modified:
7 years, 3 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Allow tab permission to be granted for chrome:// pages through activeTab. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223396

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/extensions/active_tab_permission_granter.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

not at google - send to devlin

lgtm, thanks for following that up.

7 years, 3 months ago (2013-09-16 13:46:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/24170002/1

7 years, 3 months ago (2013-09-16 16:43:52 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 3 months ago (2013-09-16 16:57:27 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/24170002/24001

7 years, 3 months ago (2013-09-16 17:47:55 UTC) #5

Message was sent while issue was closed.

Change committed as 223396