Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: content/browser/media/session/media_session.h

Issue 2416853005: Fixing naming issues in MediaSession (Closed)
Patch Set: owners Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/session/media_session.h
diff --git a/content/browser/media/session/media_session.h b/content/browser/media/session/media_session.h
index ba8f9995df9f0b30830e0765bbdac870614f5a23..9239c7854a18b18326e2c2983451e49490922982 100644
--- a/content/browser/media/session/media_session.h
+++ b/content/browser/media/session/media_session.h
@@ -26,9 +26,9 @@ enum class MediaContentType;
namespace content {
+class AudioFocusDelegate;
class AudioFocusManagerTest;
-class MediaSessionDelegate;
-class MediaSessionObserver;
+class MediaSessionPlayerObserver;
class MediaSessionStateObserver;
class MediaSessionVisibilityBrowserTest;
@@ -77,18 +77,18 @@ class MediaSession : public WebContentsObserver,
// Adds the given player to the current media session. Returns whether the
// player was successfully added. If it returns false, AddPlayer() should be
// called again later.
- CONTENT_EXPORT bool AddPlayer(MediaSessionObserver* observer,
+ CONTENT_EXPORT bool AddPlayer(MediaSessionPlayerObserver* observer,
int player_id,
media::MediaContentType media_content_type);
// Removes the given player from the current media session. Abandons audio
// focus if that was the last player in the session.
- CONTENT_EXPORT void RemovePlayer(MediaSessionObserver* observer,
+ CONTENT_EXPORT void RemovePlayer(MediaSessionPlayerObserver* observer,
int player_id);
// Removes all the players associated with |observer|. Abandons audio focus if
// these were the last players in the session.
- CONTENT_EXPORT void RemovePlayers(MediaSessionObserver* observer);
+ CONTENT_EXPORT void RemovePlayers(MediaSessionPlayerObserver* observer);
// Record that the session was ducked.
void RecordSessionDuck();
@@ -96,7 +96,7 @@ class MediaSession : public WebContentsObserver,
// Called when a player is paused in the content.
// If the paused player is the last player, we suspend the MediaSession.
// Otherwise, the paused player will be removed from the MediaSession.
- CONTENT_EXPORT void OnPlayerPaused(MediaSessionObserver* observer,
+ CONTENT_EXPORT void OnPlayerPaused(MediaSessionPlayerObserver* observer,
int player_id);
// Resume the media session.
@@ -156,14 +156,14 @@ class MediaSession : public WebContentsObserver,
friend class content::MediaSessionStateObserver;
CONTENT_EXPORT void SetDelegateForTests(
- std::unique_ptr<MediaSessionDelegate> delegate);
+ std::unique_ptr<AudioFocusDelegate> delegate);
CONTENT_EXPORT bool IsActiveForTest() const;
CONTENT_EXPORT void RemoveAllPlayersForTest();
CONTENT_EXPORT MediaSessionUmaHelper* uma_helper_for_test();
// Representation of a player for the MediaSession.
struct PlayerIdentifier {
- PlayerIdentifier(MediaSessionObserver* observer, int player_id);
+ PlayerIdentifier(MediaSessionPlayerObserver* observer, int player_id);
PlayerIdentifier(const PlayerIdentifier&) = default;
void operator=(const PlayerIdentifier&) = delete;
@@ -174,7 +174,7 @@ class MediaSession : public WebContentsObserver,
size_t operator()(const PlayerIdentifier& player_identifier) const;
};
- MediaSessionObserver* observer;
+ MediaSessionPlayerObserver* observer;
int player_id;
};
using PlayersMap = base::hash_set<PlayerIdentifier, PlayerIdentifier::Hash>;
@@ -188,7 +188,7 @@ class MediaSession : public WebContentsObserver,
State new_state);
CONTENT_EXPORT void OnResumeInternal(SuspendType suspend_type);
- // Requests audio focus to the MediaSessionDelegate.
+ // Requests audio focus to the AudioFocusDelegate.
// Returns whether the request was granted.
CONTENT_EXPORT bool RequestSystemAudioFocus(
AudioFocusManager::AudioFocusType audio_focus_type);
@@ -216,10 +216,10 @@ class MediaSession : public WebContentsObserver,
RegisterMediaSessionStateChangedCallbackForTest(
const StateChangedCallback& cb);
- CONTENT_EXPORT bool AddPepperPlayer(MediaSessionObserver* observer,
+ CONTENT_EXPORT bool AddPepperPlayer(MediaSessionPlayerObserver* observer,
int player_id);
- std::unique_ptr<MediaSessionDelegate> delegate_;
+ std::unique_ptr<AudioFocusDelegate> delegate_;
PlayersMap players_;
PlayersMap pepper_players_;

Powered by Google App Engine
This is Rietveld 408576698