media: Use native Decryptor enum types in media mojo interfaces

media: Use native Decryptor enum types in media mojo interfaces

This also fixes a bug in MojoDecryptor where DemuxerStream::Type and
Decryptor::StreamType are mix-used with static_cast.

BUG=611224, 656057
TEST=mojo_media_unittests still pass

Committed: https://crrev.com/aabcf38f71c28d32bdd6371d38dea38788f2779a
Cr-Commit-Position: refs/heads/master@{#425517}

[xhwang, 2016-10-14 21:32:21]

xhwang@chromium.org changed reviewers:
+ dcheng@chromium.org, jrummell@chromium.org

[xhwang, 2016-10-14 21:32:22]

PTAL

[dcheng, 2016-10-14 21:36:43]

mojo lgtm

https://chromiumcodereview.appspot.com/2416373002/diff/1/media/base/decryptor.h
File media/base/decryptor.h (right):

https://chromiumcodereview.appspot.com/2416373002/diff/1/media/base/decryptor...
media/base/decryptor.h:36: STATUS_MAX = kError
Nit: it's probably better to be consistent with naming styles in the enums?

[xhwang, 2016-10-14 21:40:09]

https://chromiumcodereview.appspot.com/2416373002/diff/1/media/base/decryptor.h
File media/base/decryptor.h (right):

https://chromiumcodereview.appspot.com/2416373002/diff/1/media/base/decryptor...
media/base/decryptor.h:36: STATUS_MAX = kError
On 2016/10/14 21:36:42, dcheng wrote:
> Nit: it's probably better to be consistent with naming styles in the enums?

I am not sure. I think at certain point we want to convert all of them to
UPPER_CASE per chromium coding style.

[dcheng, 2016-10-14 22:01:12]

https://codereview.chromium.org/2416373002/diff/1/media/base/decryptor.h
File media/base/decryptor.h (right):

https://codereview.chromium.org/2416373002/diff/1/media/base/decryptor.h#newc...
media/base/decryptor.h:36: STATUS_MAX = kError
On 2016/10/14 21:40:09, xhwang wrote:
> On 2016/10/14 21:36:42, dcheng wrote:
> > Nit: it's probably better to be consistent with naming styles in the enums?
> 
> I am not sure. I think at certain point we want to convert all of them to
> UPPER_CASE per chromium coding style.

Shrug, I'm not an owner of this code. But usually, I think it's a bit easier
maintenance-wise to stay consistent with a file. If we want to convert
everything later, that's fine too - but then we can make that change globally at
the time.

[jrummell, 2016-10-14 22:07:46]

lgtm

[xhwang, 2016-10-14 22:39:54]

https://chromiumcodereview.appspot.com/2416373002/diff/1/media/base/decryptor.h
File media/base/decryptor.h (right):

https://chromiumcodereview.appspot.com/2416373002/diff/1/media/base/decryptor...
media/base/decryptor.h:36: STATUS_MAX = kError
On 2016/10/14 22:01:12, dcheng wrote:
> On 2016/10/14 21:40:09, xhwang wrote:
> > On 2016/10/14 21:36:42, dcheng wrote:
> > > Nit: it's probably better to be consistent with naming styles in the
enums?
> > 
> > I am not sure. I think at certain point we want to convert all of them to
> > UPPER_CASE per chromium coding style.
> 
> Shrug, I'm not an owner of this code. But usually, I think it's a bit easier
> maintenance-wise to stay consistent with a file. If we want to convert
> everything later, that's fine too - but then we can make that change globally
at
> the time.

Agreed. I was updating this then my machine lost power. I am gonna CQ this now,
then update in a later CL.

[xhwang, 2016-10-14 22:39:58]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2016-10-14 22:40:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 00:27:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-15 00:29:14]

Description was changed from

==========
media: Use native Decryptor enum types in media mojo interfaces

This also fixes a bug in MojoDecryptor where DemuxerStream::Type and
Decryptor::StreamType are mix-used with static_cast.

BUG=611224,656057
TEST=mojo_media_unittests still pass
==========

to

==========
media: Use native Decryptor enum types in media mojo interfaces

This also fixes a bug in MojoDecryptor where DemuxerStream::Type and
Decryptor::StreamType are mix-used with static_cast.

BUG=611224,656057
TEST=mojo_media_unittests still pass

Committed: https://crrev.com/aabcf38f71c28d32bdd6371d38dea38788f2779a
Cr-Commit-Position: refs/heads/master@{#425517}
==========

[commit-bot: I haz the power, 2016-10-15 00:29:14]

Patchset 1 (id:??) landed as
https://crrev.com/aabcf38f71c28d32bdd6371d38dea38788f2779a
Cr-Commit-Position: refs/heads/master@{#425517}