Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 2416293002: Android shouldn't fire focus events when the WebView itself isn't focused (Closed)
Patch Set: Also suppress other events when no accessibility focus Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
index 1c34c0fc34a55cbe923123d1ab9b62800e53409a..b8d75208a34e429957c00391346f9906d37f398f 100644
--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
@@ -683,13 +683,16 @@ public class BrowserAccessibilityManager {
@CalledByNative
private void handleFocusChanged(int id) {
if (mNativeObj == 0) return;
- sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_FOCUSED);
- moveAccessibilityFocusToId(id);
+ if (mAccessibilityFocusId != View.NO_ID) {
+ sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_FOCUSED);
+ moveAccessibilityFocusToId(id);
+ }
}
@CalledByNative
private void handleCheckStateChanged(int id) {
if (mNativeObj == 0) return;
+ if (mAccessibilityFocusId == View.NO_ID) return;
sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_CLICKED);
}
@@ -702,18 +705,21 @@ public class BrowserAccessibilityManager {
@CalledByNative
private void handleTextSelectionChanged(int id) {
if (mNativeObj == 0) return;
+ if (mAccessibilityFocusId == View.NO_ID) return;
sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_TEXT_SELECTION_CHANGED);
}
@CalledByNative
private void handleEditableTextChanged(int id) {
if (mNativeObj == 0) return;
+ if (mAccessibilityFocusId == View.NO_ID) return;
sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_TEXT_CHANGED);
}
@CalledByNative
private void handleSliderChanged(int id) {
if (mNativeObj == 0) return;
+ if (mAccessibilityFocusId == View.NO_ID) return;
sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_SCROLLED);
}
@@ -748,7 +754,9 @@ public class BrowserAccessibilityManager {
@CalledByNative
private void handleScrolledToAnchor(int id) {
if (mNativeObj == 0) return;
- moveAccessibilityFocusToId(id);
+ if (mAccessibilityFocusId != View.NO_ID) {
+ moveAccessibilityFocusToId(id);
+ }
}
@CalledByNative
@@ -767,6 +775,7 @@ public class BrowserAccessibilityManager {
@CalledByNative
private void announceLiveRegionText(String text) {
+ if (mAccessibilityFocusId == View.NO_ID) return;
mView.announceForAccessibility(text);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698