Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2416213004: ChromeOS: removed outdated --disable-timezone-tracking-option switch. (Closed)

Created:
4 years, 2 months ago by Alexander Alekseev
Modified:
4 years, 2 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, alemate+watch_chromium.org, oshima+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, achuith+watch_chromium.org, michaelpg+watch-md-ui_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS: removed outdated --disable-timezone-tracking-option switch. BUG=653625 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d521ab5a3c8ada9490eba0a0419fc458e0854b3d Cr-Commit-Position: refs/heads/master@{#426740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -56 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/system/timezone_resolver_manager.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.js View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/date_time_handler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Alexander Alekseev
Please review.
4 years, 2 months ago (2016-10-15 03:41:16 UTC) #3
stevenjb
lgtm
4 years, 2 months ago (2016-10-17 18:38:09 UTC) #8
michaelpg
Yay thanks! Time zone logic is complicated enough as it is.
4 years, 2 months ago (2016-10-17 18:56:30 UTC) #9
michaelpg
On 2016/10/17 18:56:30, michaelpg wrote: > Yay thanks! Time zone logic is complicated enough as ...
4 years, 2 months ago (2016-10-19 23:59:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416213004/1
4 years, 2 months ago (2016-10-21 05:26:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 06:51:21 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:27:51 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d521ab5a3c8ada9490eba0a0419fc458e0854b3d
Cr-Commit-Position: refs/heads/master@{#426740}

Powered by Google App Engine
This is Rietveld 408576698