Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: content/renderer/media/external_media_stream_audio_source.cc

Issue 2416123002: Stop media stream source when audio capture error occurs. (Closed)
Patch Set: Rebase. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/local_media_stream_audio_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/external_media_stream_audio_source.cc
diff --git a/content/renderer/media/external_media_stream_audio_source.cc b/content/renderer/media/external_media_stream_audio_source.cc
index 60a68241b6fff060060078e60693b6ea43010041..7c2977c2907c46249730468bb2f63b81ffbe75a3 100644
--- a/content/renderer/media/external_media_stream_audio_source.cc
+++ b/content/renderer/media/external_media_stream_audio_source.cc
@@ -72,10 +72,7 @@ void ExternalMediaStreamAudioSource::Capture(const media::AudioBus* audio_bus,
}
void ExternalMediaStreamAudioSource::OnCaptureError(const std::string& why) {
- // As of this writing, this method doesn't get called for anything useful,
- // and all other implementors just log the message, but don't disconnect sinks
- // or take any other action. So, just log the error.
- LOG(ERROR) << why;
+ StopSourceOnError(why);
}
} // namespace content
« no previous file with comments | « no previous file | content/renderer/media/local_media_stream_audio_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698