Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 24158002: Cleaned up the print preview API used by app printing browser tests (Closed)

Created:
7 years, 3 months ago by dharcourt
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Cleaned up the print preview API used by app printing browser tests Added an anonymous namespace to make a couple of methods of this testing API private. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223363

Patch Set 1 #

Total comments: 4

Patch Set 2 : Implemented review suggestions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M chrome/browser/ui/webui/print_preview/print_preview_ui.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 3 chunks +28 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dharcourt
This is a small cleaning up follow-up on http://crrev.com/24104004. As always, thanks for the review! ...
7 years, 3 months ago (2013-09-15 10:13:37 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/24158002/diff/1/chrome/browser/ui/webui/print_preview/print_preview_ui.cc File chrome/browser/ui/webui/print_preview/print_preview_ui.cc (right): https://codereview.chromium.org/24158002/diff/1/chrome/browser/ui/webui/print_preview/print_preview_ui.cc#newcode341 chrome/browser/ui/webui/print_preview/print_preview_ui.cc:341: } // namespace Please remove lines 341-343
7 years, 3 months ago (2013-09-15 22:56:49 UTC) #2
not at google - send to devlin
lgtm, thanks for following that up Charles! https://codereview.chromium.org/24158002/diff/1/chrome/browser/ui/webui/print_preview/print_preview_ui.cc File chrome/browser/ui/webui/print_preview/print_preview_ui.cc (right): https://codereview.chromium.org/24158002/diff/1/chrome/browser/ui/webui/print_preview/print_preview_ui.cc#newcode345 chrome/browser/ui/webui/print_preview/print_preview_ui.cc:345: static int ...
7 years, 3 months ago (2013-09-16 13:45:06 UTC) #3
dharcourt
https://codereview.chromium.org/24158002/diff/1/chrome/browser/ui/webui/print_preview/print_preview_ui.cc File chrome/browser/ui/webui/print_preview/print_preview_ui.cc (right): https://codereview.chromium.org/24158002/diff/1/chrome/browser/ui/webui/print_preview/print_preview_ui.cc#newcode341 chrome/browser/ui/webui/print_preview/print_preview_ui.cc:341: } // namespace On 2013/09/15 22:56:49, Vitaly Buka wrote: ...
7 years, 3 months ago (2013-09-16 15:49:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/24158002/12001
7 years, 3 months ago (2013-09-16 15:49:17 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 18:22:37 UTC) #6
Message was sent while issue was closed.
Change committed as 223363

Powered by Google App Engine
This is Rietveld 408576698