Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2415663008: Expose Null ANGLE backend (Closed)

Created:
4 years, 2 months ago by piman
Modified:
4 years, 2 months ago
Reviewers:
Geoff Lang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose Null ANGLE backend It's not functional yet, but at least wires it up so that it can be used. BUG=602737 Committed: https://crrev.com/e92e81f7f73b52195cf224094c7e067e6e6520a9 Cr-Commit-Position: refs/heads/master@{#426301}

Patch Set 1 #

Total comments: 2

Patch Set 2 : check for EGL_ANGLE_platform_angle_null extension #

Patch Set 3 : rebase #

Patch Set 4 : Fix/Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -11 lines) Patch
M ui/gl/gl_surface_egl.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M ui/gl/gl_surface_egl.cc View 1 2 3 7 chunks +21 lines, -0 lines 0 comments Download
M ui/gl/gl_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_switches.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/test/egl_initialization_displays_unittest.cc View 1 2 3 9 chunks +20 lines, -10 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
piman
4 years, 2 months ago (2016-10-15 00:18:55 UTC) #4
Geoff Lang
On 2016/10/15 00:18:55, piman wrote: lgtm
4 years, 2 months ago (2016-10-19 16:22:58 UTC) #7
Geoff Lang
https://codereview.chromium.org/2415663008/diff/1/ui/gl/gl_surface_egl.cc File ui/gl/gl_surface_egl.cc (right): https://codereview.chromium.org/2415663008/diff/1/ui/gl/gl_surface_egl.cc#newcode376 ui/gl/gl_surface_egl.cc:376: if (requested_renderer == kANGLEImplementationNullName) We should check for the ...
4 years, 2 months ago (2016-10-19 16:23:09 UTC) #8
piman
https://codereview.chromium.org/2415663008/diff/1/ui/gl/gl_surface_egl.cc File ui/gl/gl_surface_egl.cc (right): https://codereview.chromium.org/2415663008/diff/1/ui/gl/gl_surface_egl.cc#newcode376 ui/gl/gl_surface_egl.cc:376: if (requested_renderer == kANGLEImplementationNullName) On 2016/10/19 16:23:09, Geoff Lang ...
4 years, 2 months ago (2016-10-19 18:03:01 UTC) #11
piman
On 2016/10/19 18:03:01, piman wrote: > https://codereview.chromium.org/2415663008/diff/1/ui/gl/gl_surface_egl.cc > File ui/gl/gl_surface_egl.cc (right): > > https://codereview.chromium.org/2415663008/diff/1/ui/gl/gl_surface_egl.cc#newcode376 > ...
4 years, 2 months ago (2016-10-19 19:19:31 UTC) #16
Geoff Lang
On 2016/10/19 19:19:31, piman wrote: > On 2016/10/19 18:03:01, piman wrote: > > https://codereview.chromium.org/2415663008/diff/1/ui/gl/gl_surface_egl.cc > ...
4 years, 2 months ago (2016-10-19 21:10:23 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415663008/60001
4 years, 2 months ago (2016-10-19 21:15:31 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-19 22:10:18 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:12:03 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e92e81f7f73b52195cf224094c7e067e6e6520a9
Cr-Commit-Position: refs/heads/master@{#426301}

Powered by Google App Engine
This is Rietveld 408576698