Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: Tools/Scripts/webkitpy/bindings/main.py

Issue 24156003: Revert IDL compiler build flow to Perl, rename 'deprecated' (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/Scripts/run-bindings-tests ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/bindings/main.py
diff --git a/Tools/Scripts/webkitpy/bindings/main.py b/Tools/Scripts/webkitpy/bindings/main.py
index 80d8dc6a23a449c23061cb8e48ef9792dec2cdcd..b1409d27adaff8a6415907a2ec5fd2cd4a9043f5 100644
--- a/Tools/Scripts/webkitpy/bindings/main.py
+++ b/Tools/Scripts/webkitpy/bindings/main.py
@@ -82,8 +82,9 @@ provider = ScopedTempFileProvider()
class BindingsTests(object):
- def __init__(self, reset_results, executive):
+ def __init__(self, reset_results, test_python, executive):
self.reset_results = reset_results
+ self.test_python = test_python
self.executive = executive
_, self.interface_dependencies_filename = provider.newtempfile()
if reset_results:
@@ -99,7 +100,7 @@ class BindingsTests(object):
'-Ibindings/scripts',
'-Icore/scripts',
'-I../../JSON/out/lib/perl5',
- 'bindings/scripts/deprecated_generate_bindings.pl',
+ 'bindings/scripts/generate_bindings.pl',
# idl include directories (path relative to generate-bindings.pl)
'--include', '.',
'--outputDir', output_directory,
@@ -117,7 +118,7 @@ class BindingsTests(object):
def generate_from_idl_py(self, idl_file, output_directory):
cmd = ['python',
- 'bindings/scripts/idl_compiler.py',
+ 'bindings/scripts/unstable/idl_compiler.py',
'--output-dir', output_directory,
'--idl-attributes-file', 'bindings/scripts/IDLAttributes.txt',
'--include', '.',
@@ -234,10 +235,11 @@ class BindingsTests(object):
for input_file in os.listdir(input_directory)
if input_file.endswith('.idl')])
print
- print 'Python:'
- passed &= all([generate_and_check_output_py(input_file)
- for input_file in os.listdir(input_directory)
- if input_file.endswith('.idl')])
+ if self.test_python:
+ print 'Python:'
+ passed &= all([generate_and_check_output_py(input_file)
+ for input_file in os.listdir(input_directory)
+ if input_file.endswith('.idl')])
return passed
def main(self):
« no previous file with comments | « Tools/Scripts/run-bindings-tests ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698