cc: Always check for completed raster tasks before scheduling more tasks.

cc: Always check for completed raster tasks before scheduling more tasks.

RasterWorkerPool implementations assume that canceled raster tasks
are not re-scheduled. The tile manager need to call
CheckForCompletedTasks before scheduling more tasks to enforce this.

BUG=290441
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224057

[vmpstr, 2013-09-18 20:39:36]

lgtm

https://codereview.chromium.org/24153017/diff/1/cc/resources/tile_manager.cc
File cc/resources/tile_manager.cc (right):

https://codereview.chromium.org/24153017/diff/1/cc/resources/tile_manager.cc#...
cc/resources/tile_manager.cc:400: raster_worker_pool_->CheckForCompletedTasks();
nit: Can you add a comment here, something similar to this CL description?

[reveman, 2013-09-18 21:48:30]

I changed the latest patch a bit to limit the change in behavior as much as
possible. PTAL.

https://codereview.chromium.org/24153017/diff/1/cc/resources/tile_manager.cc
File cc/resources/tile_manager.cc (right):

https://codereview.chromium.org/24153017/diff/1/cc/resources/tile_manager.cc#...
cc/resources/tile_manager.cc:400: raster_worker_pool_->CheckForCompletedTasks();
On 2013/09/18 20:39:36, vmpstr wrote:
> nit: Can you add a comment here, something similar to this CL description?

Done.

[vmpstr, 2013-09-18 21:55:14]

Makes sense, still lgtm

[commit-bot: I haz the power, 2013-09-18 21:58:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/24153017/6001

[commit-bot: I haz the power, 2013-09-18 22:49:43]

Retried try job too often on linux_rel for step(s) cc_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-09-18 23:29:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/24153017/25001

[commit-bot: I haz the power, 2013-09-18 23:39:18]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-09-19 00:26:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/24153017/25001

[commit-bot: I haz the power, 2013-09-19 06:18:30]

Change committed as 224057