Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: components/constrained_window/constrained_window_views.h

Issue 2415053002: MacViews: Support ui::MODAL_TYPE_WINDOW with a null parent window. (Closed)
Patch Set: review comments, desktop widgets, cite bug Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/constrained_window/constrained_window_views_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/constrained_window/constrained_window_views.h
diff --git a/components/constrained_window/constrained_window_views.h b/components/constrained_window/constrained_window_views.h
index 9a8b3e95f5f3f02c14387e605dff21c40a097ce4..972fca88ecfed68f9a1f3379216b8715b9db8442 100644
--- a/components/constrained_window/constrained_window_views.h
+++ b/components/constrained_window/constrained_window_views.h
@@ -73,8 +73,10 @@ views::Widget* CreateWebModalDialogViews(views::WidgetDelegate* dialog,
// Create a widget for |dialog| that has a modality given by
// |dialog->GetModalType()|. The modal type must be either
-// ui::MODAL_TYPE_SYSTEM or ui::MODAL_TYPE_WINDOW. This places the
-// dialog appropriately if |parent| is a valid browser window.
+// ui::MODAL_TYPE_SYSTEM or ui::MODAL_TYPE_WINDOW. This places the dialog
+// appropriately if |parent| is a valid browser window. Currently, |parent| may
+// be null for MODAL_TYPE_WINDOW, but that's a bug and callers shouldn't rely on
+// that working. See http://crbug.com/657293.
views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog,
gfx::NativeWindow parent);
« no previous file with comments | « no previous file | components/constrained_window/constrained_window_views_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698