Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2414853002:
[Devtools] Added popover support to network timeline canvas expirement (Closed)
|
Created:
4 years, 2 months ago by allada Modified:
4 years, 2 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Devtools] Added popover support to network timeline canvas expirement
This patch added hover/popover support to canvas timeline in network.
see: http://imgur.com/a/qlZOc
R=lushnikov,dgozman
BUG=653738
Committed: https://crrev.com/2b9dfceb47085397320ee0fbfedd3f962105d085
Cr-Commit-Position: refs/heads/master@{#426416}
Patch Set 1 : Merge branch 'NETWORK_TIMELINE_6_DRAW_DIVIDERS' into NETWORK_TIMELINE_7_POPOVER #
Total comments: 11
Patch Set 2 : Merge branch 'master' into NETWORK_TIMELINE_7_POPOVER #Patch Set 3 : changes #
Total comments: 2
Patch Set 4 : changes #
Dependent Patchsets: Messages
Total messages: 23 (10 generated)
Patchset #1 (id:1) has been deleted
PTL
Can we reuse PopoverHelper here? It does all those setTimeouts for you.
Patchset #2 (id:40001) has been deleted
PTL
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:60001) has been deleted
Andrey, could you please take a look at PopoverHelper usage?
https://codereview.chromium.org/2414853002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js (right): https://codereview.chromium.org/2414853002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:28: this._popoverAnchor = this.contentElement.createChild("div", "network-timeline-popover"); let's use AnchorBox - it's a more lightweight way to position popover https://codereview.chromium.org/2414853002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:67: WebInspector.NetworkTimelineColumn._popoverShowDelay = 300; not used https://codereview.chromium.org/2414853002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:70: willHide: function() nit: @override https://codereview.chromium.org/2414853002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:73: }, nit: new line https://codereview.chromium.org/2414853002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:83: return this._popoverAnchor; shell we inline the _positionPopoverAnchor method here? https://codereview.chromium.org/2414853002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/networkTimelineColumn.css (right): https://codereview.chromium.org/2414853002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/networkTimelineColumn.css:19: .network-timeline-popover { not gonna be needed if you use anchorBox
PTaL https://codereview.chromium.org/2414853002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js (right): https://codereview.chromium.org/2414853002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:28: this._popoverAnchor = this.contentElement.createChild("div", "network-timeline-popover"); On 2016/10/19 22:02:26, lushnikov wrote: > let's use AnchorBox - it's a more lightweight way to position popover Done. https://codereview.chromium.org/2414853002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:67: WebInspector.NetworkTimelineColumn._popoverShowDelay = 300; On 2016/10/19 22:02:25, lushnikov wrote: > not used Done. https://codereview.chromium.org/2414853002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:70: willHide: function() On 2016/10/19 22:02:25, lushnikov wrote: > nit: @override Done. https://codereview.chromium.org/2414853002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:73: }, On 2016/10/19 22:02:25, lushnikov wrote: > nit: new line Done. https://codereview.chromium.org/2414853002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:83: return this._popoverAnchor; On 2016/10/19 22:02:26, lushnikov wrote: > shell we inline the _positionPopoverAnchor method here? Acknowledged.
Patchset #3 (id:120001) has been deleted
lgtm https://codereview.chromium.org/2414853002/diff/140001/third_party/WebKit/Sou... File third_party/WebKit/Source/devtools/front_end/network/networkTimelineColumn.css (right): https://codereview.chromium.org/2414853002/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/devtools/front_end/network/networkTimelineColumn.css:19: .network-timeline-popover { not used any more
done https://codereview.chromium.org/2414853002/diff/140001/third_party/WebKit/Sou... File third_party/WebKit/Source/devtools/front_end/network/networkTimelineColumn.css (right): https://codereview.chromium.org/2414853002/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/devtools/front_end/network/networkTimelineColumn.css:19: .network-timeline-popover { On 2016/10/20 00:26:36, lushnikov wrote: > not used any more Done.
The CQ bit was checked by allada@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lushnikov@chromium.org Link to the patchset: https://codereview.chromium.org/2414853002/#ps160001 (title: "changes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Added popover support to network timeline canvas expirement This patch added hover/popover support to canvas timeline in network. see: http://imgur.com/a/qlZOc R=lushnikov,dgozman BUG=653738 ========== to ========== [Devtools] Added popover support to network timeline canvas expirement This patch added hover/popover support to canvas timeline in network. see: http://imgur.com/a/qlZOc R=lushnikov,dgozman BUG=653738 Committed: https://crrev.com/2b9dfceb47085397320ee0fbfedd3f962105d085 Cr-Commit-Position: refs/heads/master@{#426416} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/2b9dfceb47085397320ee0fbfedd3f962105d085 Cr-Commit-Position: refs/heads/master@{#426416} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
