Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2414213003: Use accessibility name of the bubble widget for ChromeVox. (Closed)

Created:
4 years, 2 months ago by jdufault
Modified:
4 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, tfarina, groby+bubble_chromium.org, rouslan+bubble_chromium.org, msw+watch_chromium.org, hcarmona+bubble_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use accessibility name of the bubble widget for ChromeVox. BUG=654913 Committed: https://crrev.com/3d7dcea8d8af892ef8137ffee267afc1f5c16a8e Cr-Commit-Position: refs/heads/master@{#426884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/views/bubble/tray_bubble_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/bubble/tray_bubble_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jdufault
stevenjb@ PTAL. Thanks!
4 years, 2 months ago (2016-10-20 19:42:08 UTC) #7
stevenjb
lgtm
4 years, 1 month ago (2016-10-21 19:44:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414213003/1
4 years, 1 month ago (2016-10-21 19:47:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-21 20:58:14 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-21 21:00:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d7dcea8d8af892ef8137ffee267afc1f5c16a8e
Cr-Commit-Position: refs/heads/master@{#426884}

Powered by Google App Engine
This is Rietveld 408576698