|
|
Created:
4 years, 2 months ago by skiazyk Modified:
4 years, 2 months ago Reviewers:
Paweł Hajdan Jr. CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix ignored parameter in TraceAnalyzer
This appears to be a bug where a parameter is ignored in one of its
members.
BUG=None
Committed: https://crrev.com/06bca199aa1931102f3f33c7911a45d46c799654
Cr-Commit-Position: refs/heads/master@{#426617}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
Description was changed from ========== Fix ignored parameter in TraceAnalyzer This appears to be a bug where a parameter is ignored in one of its members. BUG=None ========== to ========== Fix ignored parameter in TraceAnalyzer This appears to be a bug where a parameter is ignored in one of its members. BUG=None ==========
skiazyk@google.com changed reviewers: + phajdan.jr@chromium.org
The CQ bit was checked by skiazyk@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was unchecked by skiazyk@google.com
Whoa, LGTM.
The CQ bit was checked by skiazyk@google.com
The CQ bit was unchecked by skiazyk@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/10/20 16:43:33, Paweł Hajdan Jr. wrote: > Whoa, LGTM. Haha, told you it was tiny. Thanks man.
The CQ bit was checked by skiazyk@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix ignored parameter in TraceAnalyzer This appears to be a bug where a parameter is ignored in one of its members. BUG=None ========== to ========== Fix ignored parameter in TraceAnalyzer This appears to be a bug where a parameter is ignored in one of its members. BUG=None ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix ignored parameter in TraceAnalyzer This appears to be a bug where a parameter is ignored in one of its members. BUG=None ========== to ========== Fix ignored parameter in TraceAnalyzer This appears to be a bug where a parameter is ignored in one of its members. BUG=None Committed: https://crrev.com/06bca199aa1931102f3f33c7911a45d46c799654 Cr-Commit-Position: refs/heads/master@{#426617} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/06bca199aa1931102f3f33c7911a45d46c799654 Cr-Commit-Position: refs/heads/master@{#426617} |