Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2414133005: Fix ignored parameter in TraceAnalyzer (Closed)

Created:
4 years, 2 months ago by skiazyk
Modified:
4 years, 2 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ignored parameter in TraceAnalyzer This appears to be a bug where a parameter is ignored in one of its members. BUG=None Committed: https://crrev.com/06bca199aa1931102f3f33c7911a45d46c799654 Cr-Commit-Position: refs/heads/master@{#426617}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M base/test/trace_event_analyzer.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414133005/1
4 years, 2 months ago (2016-10-19 15:32:19 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-19 15:32:20 UTC) #6
Paweł Hajdan Jr.
Whoa, LGTM.
4 years, 2 months ago (2016-10-20 16:43:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414133005/1
4 years, 2 months ago (2016-10-20 17:34:26 UTC) #11
skiazyk
On 2016/10/20 16:43:33, Paweł Hajdan Jr. wrote: > Whoa, LGTM. Haha, told you it was ...
4 years, 2 months ago (2016-10-20 18:00:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414133005/1
4 years, 2 months ago (2016-10-20 20:53:41 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 22:16:24 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:23:27 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06bca199aa1931102f3f33c7911a45d46c799654
Cr-Commit-Position: refs/heads/master@{#426617}

Powered by Google App Engine
This is Rietveld 408576698