Added common layout framework for system menu rows.

ash/common/system/tray/tray_constants.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/tray/tray_constants.h"
 
 #include "ash/common/material_design/material_design_controller.h"
 #include "base/logging.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/color_palette.h"
@@ skipping 78 matching lines @@
 const int kSeparatorWidth = 1;
 
 const SkColor kHorizontalSeparatorColor = SkColorSetA(SK_ColorBLACK, 0x1F);
 const int kHorizontalSeparatorHeight = 24;
 
 int GetTrayConstant(TrayConstant constant) {
   const int kTrayItemHeightLegacy[] = {38, 38, kTrayItemSize};
   const int kTraySpacing[] = {4, 4, 0};
   const int kTrayPaddingFromEdgeOfShelf[] = {3, 3, 4};
   const int kTrayPopupItemHeight[] = {46, 46, 48};
+  // TODO(bruthig): Use the correct values for non-material design.
+  const int kTrayPopupItemLeftInset[] = {0, 0, 4};
+  // TODO(bruthig): Use the correct values for non-material design.
+  const int kTrayPopupItemRightInset[] = {0, 0, 4};
+  // TODO(bruthig): Use the correct values for non-material design.
+  const int kTrayPopupItemMinStartWidth[] = {48, 48, 48};
+  // TODO(bruthig): Use the correct values for non-material design.
+  const int kTrayPopupItemMinEndWidth[] = {48, 48, 48};

[tdanderson, 2016/10/19 18:31:00]

optional: share 48 with kMenuButtonSize

[bruthig, 2016/10/20 04:40:13]

These will get reworked in a follow-up CL.

[tdanderson, 2016/10/20 18:16:49]

Acknowledged.

   const int kVirtualKeyboardButtonSize[] = {39, 39, kTrayItemSize};
   const int kTrayImeMenuIcon[] = {40, 40, kTrayItemSize};
   const int kTrayImageItemPadding[] = {1, 1, 3};
 
   const int mode = MaterialDesignController::GetMode();
   DCHECK(mode >= MaterialDesignController::NON_MATERIAL &&
          mode <= MaterialDesignController::MATERIAL_EXPERIMENTAL);
 
   switch (constant) {
     case TRAY_ITEM_HEIGHT_LEGACY:
       return kTrayItemHeightLegacy[mode];
     case TRAY_SPACING:
       return kTraySpacing[mode];
     case TRAY_PADDING_FROM_EDGE_OF_SHELF:
       return kTrayPaddingFromEdgeOfShelf[mode];
     case TRAY_POPUP_ITEM_HEIGHT:
       return kTrayPopupItemHeight[mode];
+    case TRAY_POPUP_ITEM_LEFT_INSET:
+      return kTrayPopupItemLeftInset[mode];
+    case TRAY_POPUP_ITEM_RIGHT_INSET:
+      return kTrayPopupItemRightInset[mode];
+    case TRAY_POPUP_ITEM_MIN_START_WIDTH:
+      return kTrayPopupItemMinStartWidth[mode];
+    case TRAY_POPUP_ITEM_MIN_END_WIDTH:
+      return kTrayPopupItemMinEndWidth[mode];
     case VIRTUAL_KEYBOARD_BUTTON_SIZE:
       return kVirtualKeyboardButtonSize[mode];
     case TRAY_IME_MENU_ICON:
       return kTrayImeMenuIcon[mode];
     case TRAY_IMAGE_ITEM_PADDING:
       return kTrayImageItemPadding[mode];
   }
   NOTREACHED();
   return 0;
 }
 
 }  // namespace ash