ash: Fix crash in launcher tooltip manager

ash: Fix crash in launcher tooltip manager

Ensure tooltips are closed when their anchor views go away. Also, close the
tooltip when shelf alignment changes.

BUG=288838
TEST=added to ash_unittests LauncherViewTest

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223393

[James Cook, 2013-09-13 23:54:09]

skuhne, PTAL

https://codereview.chromium.org/24141003/diff/1/ash/launcher/launcher_view.cc
File ash/launcher/launcher_view.cc (right):

https://codereview.chromium.org/24141003/diff/1/ash/launcher/launcher_view.cc...
ash/launcher/launcher_view.cc:480: tooltip_->Close();
The fix below to close the tooltip when its launcher button is removed is
probably sufficient to fix the crash (it fixes the test I added to repro the
crash). However, it doesn't really make sense to keep tooltips open during shelf
alignment changes, so I just close them.

https://codereview.chromium.org/24141003/diff/1/ash/launcher/launcher_view_un...
File ash/launcher/launcher_view_unittest.cc (right):

https://codereview.chromium.org/24141003/diff/1/ash/launcher/launcher_view_un...
ash/launcher/launcher_view_unittest.cc:1088: TEST_F(LauncherViewTest,
RemovingItemClosesTooltip) {
This test, without the other patches, reproduces the call stack in the crash
report.

[Mr4D (OOO till 08-26), 2013-09-14 00:06:21]

lgtm (looks great to me - good tests!)

https://codereview.chromium.org/24141003/diff/1/ash/launcher/launcher_tooltip...
File ash/launcher/launcher_tooltip_manager.h (right):

https://codereview.chromium.org/24141003/diff/1/ash/launcher/launcher_tooltip...
ash/launcher/launcher_tooltip_manager.h:47: views::View* anchor() { return
anchor_; }
Hmm. Maybe something like "current_used_anchor_view"? The manager itself does
not have an anchor.

https://codereview.chromium.org/24141003/diff/1/ash/launcher/launcher_view_un...
File ash/launcher/launcher_view_unittest.cc (right):

https://codereview.chromium.org/24141003/diff/1/ash/launcher/launcher_view_un...
ash/launcher/launcher_view_unittest.cc:1088: TEST_F(LauncherViewTest,
RemovingItemClosesTooltip) {
Very nice!

[commit-bot: I haz the power, 2013-09-14 00:16:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/24141003/9001

[commit-bot: I haz the power, 2013-09-14 06:26:34]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-16 15:54:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/24141003/9001

[commit-bot: I haz the power, 2013-09-16 20:08:40]

Change committed as 223393