Issue 24140003: [SyncFS] Add generic result reciever

Issue 24140003: [SyncFS] Add generic result reciever (Closed)

Created:
7 years, 3 months ago by tzik

Modified:
7 years, 3 months ago

Reviewers:
kinuko

CC:
chromium-reviews, nhiroki+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[SyncFS] Add generic result reciever BUG=240165 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223869

Patch Set 2 : move to sync_file_system_test_util.h #

Patch Set 3 : drop extra empty line #

Patch Set 4 : explicit instantiation #

Patch Set 6 : reupload #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -57 lines)			Patch
M	chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.h	View	1	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.cc	View	1	2 chunks	+2 lines, -29 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc	View	1	11 chunks	+11 lines, -13 lines	0 comments	Download
M	chrome/browser/sync_file_system/sync_file_system_test_util.h	View	1 2 3 4	2 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/sync_file_system/sync_file_system_test_util.cc	View	1 2 3	2 chunks	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

kinuko

lgtm https://codereview.chromium.org/24140003/diff/1/chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.h File chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.h (right): https://codereview.chromium.org/24140003/diff/1/chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.h#newcode76 chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.h:76: arg1_out, arg2_out); Can we have these helpers in ...

7 years, 3 months ago (2013-09-18 07:22:23 UTC) #2

tzik

https://codereview.chromium.org/24140003/diff/1/chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.h File chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.h (right): https://codereview.chromium.org/24140003/diff/1/chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.h#newcode76 chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.h:76: arg1_out, arg2_out); On 2013/09/18 07:22:24, kinuko wrote: > Can ...

7 years, 3 months ago (2013-09-18 07:53:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/24140003/9001

7 years, 3 months ago (2013-09-18 07:55:47 UTC) #4

kinuko

On 2013/09/18 08:49:36, tzik wrote: > PTAL. > I moved them to .cc and add ...

7 years, 3 months ago (2013-09-18 10:10:58 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/24140003/36001

7 years, 3 months ago (2013-09-18 10:17:23 UTC) #7

commit-bot: I haz the power

Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=78079

7 years, 3 months ago (2013-09-18 13:45:19 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/24140003/36001

7 years, 3 months ago (2013-09-18 13:52:28 UTC) #9

Message was sent while issue was closed.

Change committed as 223869

Expand Messages | Collapse Messages