Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: chrome/browser/autofill/android/personal_data_manager_android.h

Issue 2413533003: [Payments] Normalize billing address before sending to the merchant. (Closed)
Patch Set: Addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/android/personal_data_manager_android.h
diff --git a/chrome/browser/autofill/android/personal_data_manager_android.h b/chrome/browser/autofill/android/personal_data_manager_android.h
index c6d15c79fb8220d5176a4cf19df27db9c1964c4e..2ee56421fc61687a63e9424f857cfe1c0cbf4146 100644
--- a/chrome/browser/autofill/android/personal_data_manager_android.h
+++ b/chrome/browser/autofill/android/personal_data_manager_android.h
@@ -28,6 +28,7 @@ class PersonalDataManagerAndroid
class Delegate {
public:
virtual void OnRulesSuccessfullyLoaded() = 0;
+ virtual ~Delegate() {}
};
PersonalDataManagerAndroid(JNIEnv* env, jobject obj);
@@ -298,7 +299,7 @@ class PersonalDataManagerAndroid
JNIEnv* env);
// Cancels the pending address normalization task.
- void CancelPendingAddressNormalization(
+ void CancelPendingAddressNormalizations(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& unused_obj);
@@ -340,8 +341,8 @@ class PersonalDataManagerAndroid
// The address validator used to normalize addresses.
AddressValidator address_validator_;
- // Map associating a region code to a pending normalization.
- std::map<std::string, Delegate*> pending_normalization_;
+ // Map associating a region code to pending normalizations.
+ std::map<std::string, std::vector<Delegate*>> pending_normalization_;
please use gerrit instead 2016/10/18 17:30:32 Raw pointers are scary because of possible memory
sebsg 2016/10/18 22:44:32 Done.
DISALLOW_COPY_AND_ASSIGN(PersonalDataManagerAndroid);
};

Powered by Google App Engine
This is Rietveld 408576698