Update upload.py at b7cdf3e63c5e.

Update upload.py at b7cdf3e63c5e.

R=iannucci@chromium.org
BUG=23608
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=224175

[iannucci, 2013-09-19 17:25:19]

lgtm +1 comment for upstream

https://codereview.chromium.org/24135003/diff/1/third_party/upload.py
File third_party/upload.py (right):

https://codereview.chromium.org/24135003/diff/1/third_party/upload.py#newcode...
third_party/upload.py:1618: universal_newlines=False)
isn't universal_newlines=False the default?

[chrisphan, 2013-09-19 17:45:08]

https://codereview.chromium.org/24135003/diff/1/third_party/upload.py
File third_party/upload.py (right):

https://codereview.chromium.org/24135003/diff/1/third_party/upload.py#newcode...
third_party/upload.py:1618: universal_newlines=False)
On 2013/09/19 17:25:20, iannucci wrote:
> isn't universal_newlines=False the default?

universal_newlines is False on default for popen, but default to True in
RunShellWithReturnCode

[commit-bot: I haz the power, 2013-09-19 18:48:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/24135003/1

[commit-bot: I haz the power, 2013-09-19 18:50:23]

Change committed as 224175