Clean up PerformanceCompositeTiming and PerformanceRenderTiming

Clean up PerformanceCompositeTiming and PerformanceRenderTiming

delete remnants of previous Frame Timing (obsolete version).

BUG=655384
Committed: https://crrev.com/87d3795769e4b378b3d9bdcbbec166bfb944bf4e
Cr-Commit-Position: refs/heads/master@{#426919}

[Yeol Park, 2016-10-14 12:32:08]

Description was changed from

==========
Clean up PerformanceCompositeTiming and PerformanceRenderTiming

delete remnants of previous Frame Timing (obsolete version).

BUG=655384
==========

to

==========
Clean up PerformanceCompositeTiming and PerformanceRenderTiming

delete remnants of previous Frame Timing (obsolete version).

BUG=655384
==========

[Yeol Park, 2016-10-14 12:32:08]

peary2@gmail.com changed reviewers:
+ aelias@chromium.org, ager@chromium.org, dpranke@chromium.org,
panicker@chromium.org

[Yeol Park, 2016-10-14 12:32:52]

PTAL :)

dpranke@ for
third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
ager@ for third_party/WebKit/Source/core/*
aelias@ for third_party/WebKit/Source/web/tests/WebViewTest.cpp

[aelias_OOO_until_Jul13, 2016-10-14 18:38:01]

Source/web lgtm

[panicker, 2016-10-14 18:46:25]

Thanks for the quick fix!
(non owner) LGTM

[Dirk Pranke, 2016-10-15 17:27:54]

LayoutTests/ change LGTM , but you don't actually need my approval; most
committers can approve any layout test change.

[Yeol Park, 2016-10-17 02:13:22]

peary2@gmail.com changed reviewers:
+ alexis.menard@intel.com

[Yeol Park, 2016-10-17 02:13:49]

+alexis.menard@ for third_party/WebKit/Source/core/*

PTAL :)

[Yeol Park, 2016-10-17 02:17:55]

peary2@gmail.com changed reviewers:
+ schenney@chromium.org

[Yeol Park, 2016-10-17 02:18:27]

+schenney@ for third_party/WebKit/Source/core/*

[Stephen Chennney, 2016-10-17 17:42:50]

Can the two methods that now do nothing be deleted entirely?

https://codereview.chromium.org/2413353003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceBase.cpp (right):

https://codereview.chromium.org/2413353003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:309: void
PerformanceBase::addRenderTiming(Document* initiatorDocument,
These can just always immediately return without doing anything now.

https://codereview.chromium.org/2413353003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:317: void
PerformanceBase::addCompositeTiming(Document* initiatorDocument,
This one also always does nothing.

[panicker, 2016-10-17 17:50:20]

https://codereview.chromium.org/2413353003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceBase.cpp (right):

https://codereview.chromium.org/2413353003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:309: void
PerformanceBase::addRenderTiming(Document* initiatorDocument,
On 2016/10/17 17:42:50, Stephen Chennney wrote:
> These can just always immediately return without doing anything now.

Yes addRenderTiming and addCompositeTiming should be deleted.

[Yeol Park, 2016-10-18 10:34:07]

I had update patch for delete addRenderTiming and addCompositeTiming :)
Could you run build bot?

[Yeol Park, 2016-10-20 03:43:43]

The CQ bit was checked by peary2@gmail.com

[Yeol Park, 2016-10-20 03:43:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, aelias@chromium.org, panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2413353003/#ps20001
(title: "Clean up PerformanceCompositeTiming and PerformanceRenderTiming")

[Yeol Park, 2016-10-20 03:43:52]

The CQ bit was unchecked by peary2@gmail.com

[panicker, 2016-10-21 20:29:12]

The CQ bit was checked by panicker@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 20:29:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 22:21:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:21:59]

Dry run: This issue passed the CQ dry run.

[panicker, 2016-10-21 22:23:57]

The CQ bit was checked by panicker@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:24:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 22:47:21]

Description was changed from

==========
Clean up PerformanceCompositeTiming and PerformanceRenderTiming

delete remnants of previous Frame Timing (obsolete version).

BUG=655384
==========

to

==========
Clean up PerformanceCompositeTiming and PerformanceRenderTiming

delete remnants of previous Frame Timing (obsolete version).

BUG=655384
==========

[commit-bot: I haz the power, 2016-10-21 22:47:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 22:53:08]

Description was changed from

==========
Clean up PerformanceCompositeTiming and PerformanceRenderTiming

delete remnants of previous Frame Timing (obsolete version).

BUG=655384
==========

to

==========
Clean up PerformanceCompositeTiming and PerformanceRenderTiming

delete remnants of previous Frame Timing (obsolete version).

BUG=655384

Committed: https://crrev.com/87d3795769e4b378b3d9bdcbbec166bfb944bf4e
Cr-Commit-Position: refs/heads/master@{#426919}
==========

[commit-bot: I haz the power, 2016-10-21 22:53:09]

Patchset 2 (id:??) landed as
https://crrev.com/87d3795769e4b378b3d9bdcbbec166bfb944bf4e
Cr-Commit-Position: refs/heads/master@{#426919}