Issue 24127003: [Android] Set correct ICU default local for renderer processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24127003: [Android] Set correct ICU default local for renderer processes. (Closed)

Created:
7 years, 3 months ago by Kibeom Kim (inactive)

Modified:
7 years, 3 months ago

Reviewers:
cpu_(ooo_6.6-7.5), acleung1, newt (away)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] Set correct ICU default local for renderer processes. For Android renderer processes, base::i18n::SetICUDefaultLocale was not called. So base::i18n::IsRTL() returned incorrect value which made offline error html page's text direction incorrect. Therefore, call base::i18n::SetICUDefaultLocale on renderer process initialization. BUG=288371 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223306

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/app/chrome_main_delegate.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/24127003/1

7 years, 3 months ago (2013-09-15 20:34:25 UTC) #3

Message was sent while issue was closed.

Change committed as 223306

Expand Messages | Collapse Messages