WIP: Add MemoryCoordinator::GetCurrentMemoryState

WIP: Add MemoryCoordinator::GetCurrentMemoryState

This depends on crrev/2374343002

BUG=

Committed: https://crrev.com/f210a384e1b4b5b38b911dfdddc4dc6055615050
Cr-Commit-Position: refs/heads/master@{#425916}

[hajimehoshi, 2016-10-13 08:37:10]

hajimehoshi@chromium.org changed reviewers:
+ bashi@chromium.org, chrisha@chromium.org, haraken@chromium.org

[hajimehoshi, 2016-10-13 08:37:11]

(This is WIP)

[haraken, 2016-10-13 08:38:27]

Would you upload a diff from crrev/2374343002?

[hajimehoshi, 2016-10-13 08:49:45]

On 2016/10/13 08:38:27, haraken wrote:
> Would you upload a diff from crrev/2374343002?

Done (I didn't know I could do that!)

[haraken, 2016-10-13 09:27:20]

Can you add a test?

https://codereview.chromium.org/2412413002/diff/20001/content/browser/memory/...
File content/browser/memory/memory_coordinator.h (right):

https://codereview.chromium.org/2412413002/diff/20001/content/browser/memory/...
content/browser/memory/memory_coordinator.h:55: virtual base::MemoryState
GetCurrentState() const = 0;

GetCurrentMemoryState

[chrisha, 2016-10-13 13:34:16]

+1 to haraken's comment. Also please rename the CL to reflect this.

[bashi, 2016-10-13 23:16:35]

Thanks for the CL! I'll try to submit my CL as soon as possible :)

https://codereview.chromium.org/2412413002/diff/20001/content/browser/memory/...
File content/browser/memory/memory_coordinator.h (right):

https://codereview.chromium.org/2412413002/diff/20001/content/browser/memory/...
content/browser/memory/memory_coordinator.h:55: virtual base::MemoryState
GetCurrentState() const = 0;
On 2016/10/13 09:27:20, haraken wrote:
> 
> GetCurrentMemoryState

nit: I'd prefer to return UNKNOWN so that TestMemoryCoordinator donesn't have to
override it.

[hajimehoshi, 2016-10-14 07:00:51]

Description was changed from

==========
WIP: Add MemoryCoordinator::GetCurrentThread

This depends on crrev/2374343002

BUG=
==========

to

==========
WIP: Add MemoryCoordinator::GetCurrentMemoryState

This depends on crrev/2374343002

BUG=
==========

[hajimehoshi, 2016-10-14 07:35:20]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 07:35:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hajimehoshi, 2016-10-14 07:37:17]

The CQ bit was unchecked by hajimehoshi@chromium.org

[hajimehoshi, 2016-10-14 07:37:48]

Thank you!

https://codereview.chromium.org/2412413002/diff/20001/content/browser/memory/...
File content/browser/memory/memory_coordinator.h (right):

https://codereview.chromium.org/2412413002/diff/20001/content/browser/memory/...
content/browser/memory/memory_coordinator.h:55: virtual base::MemoryState
GetCurrentState() const = 0;
On 2016/10/13 23:16:34, bashi1 wrote:
> On 2016/10/13 09:27:20, haraken wrote:
> > 
> > GetCurrentMemoryState
> 
> nit: I'd prefer to return UNKNOWN so that TestMemoryCoordinator donesn't have
to
> override it.

Done.

[haraken, 2016-10-14 10:19:26]

LGTM

[chrisha, 2016-10-14 19:56:53]

lgtm!

[bashi, 2016-10-16 23:17:27]

lgtm

[hajimehoshi, 2016-10-18 06:18:16]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2016-10-18 06:18:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, chrisha@chromium.org, bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/2412413002/#ps60001
(title: "(rebase)")

[commit-bot: I haz the power, 2016-10-18 06:18:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 07:11:12]

Description was changed from

==========
WIP: Add MemoryCoordinator::GetCurrentMemoryState

This depends on crrev/2374343002

BUG=
==========

to

==========
WIP: Add MemoryCoordinator::GetCurrentMemoryState

This depends on crrev/2374343002

BUG=
==========

[commit-bot: I haz the power, 2016-10-18 07:11:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-18 07:13:12]

Description was changed from

==========
WIP: Add MemoryCoordinator::GetCurrentMemoryState

This depends on crrev/2374343002

BUG=
==========

to

==========
WIP: Add MemoryCoordinator::GetCurrentMemoryState

This depends on crrev/2374343002

BUG=

Committed: https://crrev.com/f210a384e1b4b5b38b911dfdddc4dc6055615050
Cr-Commit-Position: refs/heads/master@{#425916}
==========

[commit-bot: I haz the power, 2016-10-18 07:13:13]

Patchset 4 (id:??) landed as
https://crrev.com/f210a384e1b4b5b38b911dfdddc4dc6055615050
Cr-Commit-Position: refs/heads/master@{#425916}

[hajimehoshi, 2016-10-18 09:17:53]

On 2016/10/18 07:13:13, commit-bot: I haz the power wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/f210a384e1b4b5b38b911dfdddc4dc6055615050
> Cr-Commit-Position: refs/heads/master@{#425916}

Oooops, I should have fixed the title and the description!