Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6265)

Unified Diff: chrome/browser/ui/search/instant_extended_interactive_uitest.cc

Issue 2412093002: Remove obsolete parts of InstantExtended tests (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/instant.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/instant_extended_interactive_uitest.cc
diff --git a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
index 2e70e92ea205a6cb92b52b2f0cc25660125de86d..904970dcd2da75a183309a819cc70bc55e10854e 100644
--- a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
+++ b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
@@ -137,10 +137,7 @@ class InstantExtendedTest : public InProcessBrowserTest,
: on_most_visited_change_calls_(0),
most_visited_items_count_(0),
first_most_visited_item_id_(0),
- on_native_suggestions_calls_(0),
- on_change_calls_(0),
submit_count_(0),
- on_esc_key_press_event_calls_(0),
on_focus_changed_calls_(0),
is_focused_(false) {}
@@ -172,22 +169,15 @@ class InstantExtendedTest : public InProcessBrowserTest,
&most_visited_items_count_) &&
GetIntFromJS(contents, "firstMostVisitedItemId",
&first_most_visited_item_id_) &&
- GetIntFromJS(contents, "onNativeSuggestionsCalls",
- &on_native_suggestions_calls_) &&
- GetIntFromJS(contents, "onChangeCalls",
- &on_change_calls_) &&
GetIntFromJS(contents, "submitCount",
&submit_count_) &&
GetStringFromJS(contents, "apiHandle.value",
&query_value_) &&
- GetIntFromJS(contents, "onEscKeyPressedCalls",
- &on_esc_key_press_event_calls_) &&
GetIntFromJS(contents, "onFocusChangedCalls",
&on_focus_changed_calls_) &&
GetBoolFromJS(contents, "isFocused",
&is_focused_) &&
GetStringFromJS(contents, "prefetchQuery", &prefetch_query_value_);
-
}
TemplateURL* GetDefaultSearchProviderTemplateURL() {
@@ -238,10 +228,7 @@ class InstantExtendedTest : public InProcessBrowserTest,
int on_most_visited_change_calls_;
int most_visited_items_count_;
int first_most_visited_item_id_;
- int on_native_suggestions_calls_;
- int on_change_calls_;
int submit_count_;
- int on_esc_key_press_event_calls_;
std::string query_value_;
int on_focus_changed_calls_;
bool is_focused_;
@@ -579,7 +566,6 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest,
// Set the text and press enter to navigate from NTP.
SetOmniboxText("Pen");
PressEnterAndWaitForNavigation();
- EXPECT_EQ(ASCIIToUTF16("Pen"), omnibox()->GetText());
observer.Wait();
// Navigate back to NTP.
« no previous file with comments | « no previous file | chrome/test/data/instant.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698