Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2412093002: Remove obsolete parts of InstantExtended tests (Closed)

Created:
4 years, 2 months ago by Marc Treib
Modified:
4 years, 2 months ago
Reviewers:
Jered, kmadhusu
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete parts of InstantExtended tests BUG=627747 Committed: https://crrev.com/15fae240034d7b43b8156d36fb12e64fe274499b Cr-Commit-Position: refs/heads/master@{#426495}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -196 lines) Patch
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 4 chunks +0 lines, -14 lines 0 comments Download
D chrome/test/data/instant.html View 1 chunk +0 lines, -50 lines 0 comments Download
M chrome/test/data/instant_extended.html View 3 chunks +2 lines, -66 lines 0 comments Download
M chrome/test/data/instant_extended_ntp.html View 3 chunks +2 lines, -66 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Marc Treib
PTAL!
4 years, 2 months ago (2016-10-12 13:06:17 UTC) #2
Marc Treib
On 2016/10/12 13:06:17, Marc Treib wrote: > PTAL! Ping!
4 years, 2 months ago (2016-10-17 11:41:37 UTC) #3
Marc Treib
On 2016/10/17 11:41:37, Marc Treib wrote: > On 2016/10/12 13:06:17, Marc Treib wrote: > > ...
4 years, 2 months ago (2016-10-18 15:09:07 UTC) #4
Marc Treib
+jered - could you take a look please? Thanks!
4 years, 2 months ago (2016-10-20 08:39:45 UTC) #6
Jered
On 2016/10/20 08:39:45, Marc Treib wrote: > +jered - could you take a look please? ...
4 years, 2 months ago (2016-10-20 14:11:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412093002/20001
4 years, 2 months ago (2016-10-20 16:09:38 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 16:25:21 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:18:54 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/15fae240034d7b43b8156d36fb12e64fe274499b
Cr-Commit-Position: refs/heads/master@{#426495}

Powered by Google App Engine
This is Rietveld 408576698