LayoutTests/screen_orientation/screenorientation-api.html - Issue 241203003: Screen Orientation: fire event on Window instead of Screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/screen_orientation/screenorientation-api.html

Issue 241203003: Screen Orientation: fire event on Window instead of Screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@ScreenOrientationUndefined

Patch Set: fix tests Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/screen_orientation/orientationchange-event.html ('k') | LayoutTests/screen_orientation/screenorientation-api-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/screen_orientation/screenorientation-api.html

diff --git a/LayoutTests/screen_orientation/screenorientation-api.html b/LayoutTests/screen_orientation/screenorientation-api.html

index 66dc845c27d44c265cdd14ae6431f8577e36b5c5..366791c7a72eccc8dd1c511c5b53c08fed6f9bd2 100644

--- a/LayoutTests/screen_orientation/screenorientation-api.html

+++ b/LayoutTests/screen_orientation/screenorientation-api.html

@@ -8,12 +8,7 @@ description("Validates the Screen Orientation API is exposed.");

shouldBeDefined("screen.lockOrientation");

shouldBeDefined("screen.unlockOrientation");

shouldBeDefined("screen.orientation");

-shouldBeDefined("screen.onorientationchange");

-// Screen should be an EventTarget

-shouldBe("screen.__proto__.__proto__", "EventTarget.prototype");

-shouldBeDefined("screen.addEventListener");

-shouldBeDefined("screen.removeEventListener");

-shouldBeDefined("screen.dispatchEvent");

+shouldBeDefined("window.onorientationchange");

</script>

</body>

</html>