Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24120005: Cleanup and IWYU-ify CocoaProfileTest and related tests. (Closed)

Created:
7 years, 3 months ago by Bernhard Bauer
Modified:
7 years, 3 months ago
Reviewers:
Avi (use Gerrit), Nico
CC:
chromium-reviews, extensions-reviews_chromium.org, jennb, tfarina, Dmitry Titov, dcheng, jianli, chromium-apps-reviews_chromium.org, James Su
Visibility:
Public.

Description

Cleanup and IWYU-ify CocoaProfileTest and related tests. Remove unnecessary includes from headers and move them to implementation files, and use TestBrowserThreadBundle. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223429

Patch Set 1 #

Patch Set 2 : fix? #

Patch Set 3 : sync #

Patch Set 4 : fix #

Total comments: 6

Patch Set 5 : include order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -46 lines) Patch
M chrome/browser/app_controller_mac_unittest.mm View 2 chunks +9 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/cocoa_profile_test.h View 2 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/cocoa_profile_test.mm View 1 1 chunk +10 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/first_run_bubble_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_cocoa_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profile_menu_controller_unittest.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/window_size_autosaver_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Bernhard Bauer
Please review.
7 years, 3 months ago (2013-09-16 12:54:01 UTC) #1
Avi (use Gerrit)
On 2013/09/16 12:54:01, Bernhard Bauer wrote: > Please review. FYI I am not an OWNER ...
7 years, 3 months ago (2013-09-16 16:08:20 UTC) #2
Avi (use Gerrit)
All files LGTM with alphabetizing fixes. https://codereview.chromium.org/24120005/diff/20001/chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm File chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm (right): https://codereview.chromium.org/24120005/diff/20001/chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm#newcode16 chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm:16: #include "chrome/common/pref_names.h" alphabetical ...
7 years, 3 months ago (2013-09-16 16:15:19 UTC) #3
Bernhard Bauer
Nico, can I get an OWNERS review?
7 years, 3 months ago (2013-09-16 16:33:06 UTC) #4
Bernhard Bauer
(Forgot to send out drafts) https://codereview.chromium.org/24120005/diff/20001/chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm File chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm (right): https://codereview.chromium.org/24120005/diff/20001/chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm#newcode16 chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm:16: #include "chrome/common/pref_names.h" On 2013/09/16 ...
7 years, 3 months ago (2013-09-16 17:31:44 UTC) #5
Nico
lgtm
7 years, 3 months ago (2013-09-16 18:32:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/24120005/32001
7 years, 3 months ago (2013-09-16 18:54:52 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 21:47:34 UTC) #8
Message was sent while issue was closed. 
Change committed as 223429

Powered by Google App Engine
This is Rietveld 408576698