Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: test/cctest/interpreter/bytecode_expectations/LetVariable.golden

Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/bytecode_expectations/LetVariable.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/LetVariable.golden b/test/cctest/interpreter/bytecode_expectations/LetVariable.golden
index d9d8f79e0a7c17f61ec34cb96215ffa331d412f8..74709fdab915e976827d1eaf995342982e905f0d 100644
--- a/test/cctest/interpreter/bytecode_expectations/LetVariable.golden
+++ b/test/cctest/interpreter/bytecode_expectations/LetVariable.golden
@@ -30,23 +30,19 @@ handlers: [
snippet: "
let x = 10; return x;
"
-frame size: 2
+frame size: 1
parameter count: 1
-bytecode array length: 20
+bytecode array length: 10
bytecodes: [
B(LdaTheHole),
B(Star), R(0),
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaSmi), U8(10),
B(Star), R(0),
- /* 46 S> */ B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(0),
- B(Star), R(1),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(1), U8(1),
+ /* 46 S> */ B(Nop),
/* 56 S> */ B(Return),
]
constant pool: [
- ONE_BYTE_INTERNALIZED_STRING_TYPE ["x"],
]
handlers: [
]
@@ -84,9 +80,9 @@ handlers: [
snippet: "
let x = 10; x = 20;
"
-frame size: 3
+frame size: 1
parameter count: 1
-bytecode array length: 30
+bytecode array length: 14
bytecodes: [
B(LdaTheHole),
B(Star), R(0),
@@ -94,18 +90,11 @@ bytecodes: [
/* 42 S> */ B(LdaSmi), U8(10),
B(Star), R(0),
/* 46 S> */ B(LdaSmi), U8(20),
- B(Star), R(1),
- B(Ldar), R(0),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(0),
- B(Star), R(2),
- /* 48 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(2), U8(1),
- B(Mov), R(1), R(0),
+ B(Star), R(0),
B(LdaUndefined),
/* 54 S> */ B(Return),
]
constant pool: [
- ONE_BYTE_INTERNALIZED_STRING_TYPE ["x"],
]
handlers: [
]

Powered by Google App Engine
This is Rietveld 408576698