Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: src/interpreter/bytecode-generator.h

Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/x87/full-codegen-x87.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-generator.h
diff --git a/src/interpreter/bytecode-generator.h b/src/interpreter/bytecode-generator.h
index 0447aa8f4522e161c3502e95710f5e02364ddeb2..d8020d6c9f9689314f809b89de776c593cbe4b5f 100644
--- a/src/interpreter/bytecode-generator.h
+++ b/src/interpreter/bytecode-generator.h
@@ -94,16 +94,14 @@ class BytecodeGenerator final : public AstVisitor<BytecodeGenerator> {
void VisitPropertyLoad(Register obj, Property* expr);
void VisitPropertyLoadForAccumulator(Register obj, Property* expr);
- void VisitVariableLoad(Variable* variable, FeedbackVectorSlot slot,
+ void BuildVariableLoad(Variable* variable, FeedbackVectorSlot slot,
+ bool needs_hole_check,
TypeofMode typeof_mode = NOT_INSIDE_TYPEOF);
- void VisitVariableLoadForAccumulatorValue(
- Variable* variable, FeedbackVectorSlot slot,
+ void BuildVariableLoadForAccumulatorValue(
+ Variable* variable, FeedbackVectorSlot slot, bool needs_hole_check,
TypeofMode typeof_mode = NOT_INSIDE_TYPEOF);
- MUST_USE_RESULT Register
- VisitVariableLoadForRegisterValue(Variable* variable, FeedbackVectorSlot slot,
- TypeofMode typeof_mode = NOT_INSIDE_TYPEOF);
- void VisitVariableAssignment(Variable* variable, Token::Value op,
- FeedbackVectorSlot slot);
+ void BuildVariableAssignment(Variable* variable, Token::Value op,
+ FeedbackVectorSlot slot, bool needs_hole_check);
void BuildReturn();
void BuildReThrow();
@@ -111,7 +109,6 @@ class BytecodeGenerator final : public AstVisitor<BytecodeGenerator> {
void BuildThrowIfHole(Handle<String> name);
void BuildThrowIfNotHole(Handle<String> name);
void BuildThrowReferenceError(Handle<String> name);
- void BuildHoleCheckForVariableLoad(Variable* variable);
void BuildHoleCheckForVariableAssignment(Variable* variable, Token::Value op);
// Build jump to targets[value], where
« no previous file with comments | « src/full-codegen/x87/full-codegen-x87.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698