Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: src/full-codegen/x87/full-codegen-x87.cc

Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/interpreter/bytecode-generator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1184 matching lines...) Expand 10 before | Expand all | Expand 10 after
1195 break; 1195 break;
1196 } 1196 }
1197 1197
1198 case VariableLocation::PARAMETER: 1198 case VariableLocation::PARAMETER:
1199 case VariableLocation::LOCAL: 1199 case VariableLocation::LOCAL:
1200 case VariableLocation::CONTEXT: { 1200 case VariableLocation::CONTEXT: {
1201 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode); 1201 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode);
1202 Comment cmnt(masm_, var->IsContextSlot() ? "[ Context variable" 1202 Comment cmnt(masm_, var->IsContextSlot() ? "[ Context variable"
1203 : "[ Stack variable"); 1203 : "[ Stack variable");
1204 1204
1205 if (NeedsHoleCheckForLoad(proxy)) { 1205 if (proxy->needs_hole_check()) {
1206 // Throw a reference error when using an uninitialized let/const 1206 // Throw a reference error when using an uninitialized let/const
1207 // binding in harmony mode. 1207 // binding in harmony mode.
1208 Label done; 1208 Label done;
1209 GetVar(eax, var); 1209 GetVar(eax, var);
1210 __ cmp(eax, isolate()->factory()->the_hole_value()); 1210 __ cmp(eax, isolate()->factory()->the_hole_value());
1211 __ j(not_equal, &done, Label::kNear); 1211 __ j(not_equal, &done, Label::kNear);
1212 __ push(Immediate(var->name())); 1212 __ push(Immediate(var->name()));
1213 __ CallRuntime(Runtime::kThrowReferenceError); 1213 __ CallRuntime(Runtime::kThrowReferenceError);
1214 __ bind(&done); 1214 __ bind(&done);
1215 context()->Plug(eax); 1215 context()->Plug(eax);
(...skipping 2299 matching lines...) Expand 10 before | Expand all | Expand 10 after
3515 isolate->builtins()->OnStackReplacement()->entry(), 3515 isolate->builtins()->OnStackReplacement()->entry(),
3516 Assembler::target_address_at(call_target_address, unoptimized_code)); 3516 Assembler::target_address_at(call_target_address, unoptimized_code));
3517 return ON_STACK_REPLACEMENT; 3517 return ON_STACK_REPLACEMENT;
3518 } 3518 }
3519 3519
3520 3520
3521 } // namespace internal 3521 } // namespace internal
3522 } // namespace v8 3522 } // namespace v8
3523 3523
3524 #endif // V8_TARGET_ARCH_X87 3524 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/interpreter/bytecode-generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698