Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1270 matching lines...) Expand 10 before | Expand all | Expand 10 after
1281 context()->Plug(v0); 1281 context()->Plug(v0);
1282 break; 1282 break;
1283 } 1283 }
1284 1284
1285 case VariableLocation::PARAMETER: 1285 case VariableLocation::PARAMETER:
1286 case VariableLocation::LOCAL: 1286 case VariableLocation::LOCAL:
1287 case VariableLocation::CONTEXT: { 1287 case VariableLocation::CONTEXT: {
1288 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode); 1288 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode);
1289 Comment cmnt(masm_, var->IsContextSlot() ? "[ Context variable" 1289 Comment cmnt(masm_, var->IsContextSlot() ? "[ Context variable"
1290 : "[ Stack variable"); 1290 : "[ Stack variable");
1291 if (NeedsHoleCheckForLoad(proxy)) { 1291 if (proxy->needs_hole_check()) {
1292 // Throw a reference error when using an uninitialized let/const 1292 // Throw a reference error when using an uninitialized let/const
1293 // binding in harmony mode. 1293 // binding in harmony mode.
1294 Label done; 1294 Label done;
1295 GetVar(v0, var); 1295 GetVar(v0, var);
1296 __ LoadRoot(at, Heap::kTheHoleValueRootIndex); 1296 __ LoadRoot(at, Heap::kTheHoleValueRootIndex);
1297 __ dsubu(at, v0, at); // Sub as compare: at == 0 on eq. 1297 __ dsubu(at, v0, at); // Sub as compare: at == 0 on eq.
1298 __ Branch(&done, ne, at, Operand(zero_reg)); 1298 __ Branch(&done, ne, at, Operand(zero_reg));
1299 __ li(a0, Operand(var->name())); 1299 __ li(a0, Operand(var->name()));
1300 __ push(a0); 1300 __ push(a0);
1301 __ CallRuntime(Runtime::kThrowReferenceError); 1301 __ CallRuntime(Runtime::kThrowReferenceError);
(...skipping 2341 matching lines...) Expand 10 before | Expand all | Expand 10 after
3643 reinterpret_cast<uint64_t>( 3643 reinterpret_cast<uint64_t>(
3644 isolate->builtins()->OnStackReplacement()->entry())); 3644 isolate->builtins()->OnStackReplacement()->entry()));
3645 return ON_STACK_REPLACEMENT; 3645 return ON_STACK_REPLACEMENT;
3646 } 3646 }
3647 3647
3648 3648
3649 } // namespace internal 3649 } // namespace internal
3650 } // namespace v8 3650 } // namespace v8
3651 3651
3652 #endif // V8_TARGET_ARCH_MIPS64 3652 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698