Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1269 matching lines...) Expand 10 before | Expand all | Expand 10 after
1280 context()->Plug(v0); 1280 context()->Plug(v0);
1281 break; 1281 break;
1282 } 1282 }
1283 1283
1284 case VariableLocation::PARAMETER: 1284 case VariableLocation::PARAMETER:
1285 case VariableLocation::LOCAL: 1285 case VariableLocation::LOCAL:
1286 case VariableLocation::CONTEXT: { 1286 case VariableLocation::CONTEXT: {
1287 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode); 1287 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode);
1288 Comment cmnt(masm_, var->IsContextSlot() ? "[ Context variable" 1288 Comment cmnt(masm_, var->IsContextSlot() ? "[ Context variable"
1289 : "[ Stack variable"); 1289 : "[ Stack variable");
1290 if (NeedsHoleCheckForLoad(proxy)) { 1290 if (proxy->needs_hole_check()) {
1291 // Throw a reference error when using an uninitialized let/const 1291 // Throw a reference error when using an uninitialized let/const
1292 // binding in harmony mode. 1292 // binding in harmony mode.
1293 Label done; 1293 Label done;
1294 GetVar(v0, var); 1294 GetVar(v0, var);
1295 __ LoadRoot(at, Heap::kTheHoleValueRootIndex); 1295 __ LoadRoot(at, Heap::kTheHoleValueRootIndex);
1296 __ subu(at, v0, at); // Sub as compare: at == 0 on eq. 1296 __ subu(at, v0, at); // Sub as compare: at == 0 on eq.
1297 __ Branch(&done, ne, at, Operand(zero_reg)); 1297 __ Branch(&done, ne, at, Operand(zero_reg));
1298 __ li(a0, Operand(var->name())); 1298 __ li(a0, Operand(var->name()));
1299 __ push(a0); 1299 __ push(a0);
1300 __ CallRuntime(Runtime::kThrowReferenceError); 1300 __ CallRuntime(Runtime::kThrowReferenceError);
(...skipping 2335 matching lines...) Expand 10 before | Expand all | Expand 10 after
3636 reinterpret_cast<uint32_t>( 3636 reinterpret_cast<uint32_t>(
3637 isolate->builtins()->OnStackReplacement()->entry())); 3637 isolate->builtins()->OnStackReplacement()->entry()));
3638 return ON_STACK_REPLACEMENT; 3638 return ON_STACK_REPLACEMENT;
3639 } 3639 }
3640 3640
3641 3641
3642 } // namespace internal 3642 } // namespace internal
3643 } // namespace v8 3643 } // namespace v8
3644 3644
3645 #endif // V8_TARGET_ARCH_MIPS 3645 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698