Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Side by Side Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/full-codegen.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1192 matching lines...) Expand 10 before | Expand all | Expand 10 after
1203 break; 1203 break;
1204 } 1204 }
1205 1205
1206 case VariableLocation::PARAMETER: 1206 case VariableLocation::PARAMETER:
1207 case VariableLocation::LOCAL: 1207 case VariableLocation::LOCAL:
1208 case VariableLocation::CONTEXT: { 1208 case VariableLocation::CONTEXT: {
1209 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode); 1209 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode);
1210 Comment cmnt(masm_, var->IsContextSlot() ? "[ Context variable" 1210 Comment cmnt(masm_, var->IsContextSlot() ? "[ Context variable"
1211 : "[ Stack variable"); 1211 : "[ Stack variable");
1212 1212
1213 if (NeedsHoleCheckForLoad(proxy)) { 1213 if (proxy->needs_hole_check()) {
1214 // Throw a reference error when using an uninitialized let/const 1214 // Throw a reference error when using an uninitialized let/const
1215 // binding in harmony mode. 1215 // binding in harmony mode.
1216 Label done; 1216 Label done;
1217 GetVar(eax, var); 1217 GetVar(eax, var);
1218 __ cmp(eax, isolate()->factory()->the_hole_value()); 1218 __ cmp(eax, isolate()->factory()->the_hole_value());
1219 __ j(not_equal, &done, Label::kNear); 1219 __ j(not_equal, &done, Label::kNear);
1220 __ push(Immediate(var->name())); 1220 __ push(Immediate(var->name()));
1221 __ CallRuntime(Runtime::kThrowReferenceError); 1221 __ CallRuntime(Runtime::kThrowReferenceError);
1222 __ bind(&done); 1222 __ bind(&done);
1223 context()->Plug(eax); 1223 context()->Plug(eax);
(...skipping 2299 matching lines...) Expand 10 before | Expand all | Expand 10 after
3523 isolate->builtins()->OnStackReplacement()->entry(), 3523 isolate->builtins()->OnStackReplacement()->entry(),
3524 Assembler::target_address_at(call_target_address, unoptimized_code)); 3524 Assembler::target_address_at(call_target_address, unoptimized_code));
3525 return ON_STACK_REPLACEMENT; 3525 return ON_STACK_REPLACEMENT;
3526 } 3526 }
3527 3527
3528 3528
3529 } // namespace internal 3529 } // namespace internal
3530 } // namespace v8 3530 } // namespace v8
3531 3531
3532 #endif // V8_TARGET_ARCH_IA32 3532 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/full-codegen/full-codegen.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698