Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/full-codegen.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1257 matching lines...) Expand 10 before | Expand all | Expand 10 after
1268 break; 1268 break;
1269 } 1269 }
1270 1270
1271 case VariableLocation::PARAMETER: 1271 case VariableLocation::PARAMETER:
1272 case VariableLocation::LOCAL: 1272 case VariableLocation::LOCAL:
1273 case VariableLocation::CONTEXT: { 1273 case VariableLocation::CONTEXT: {
1274 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode); 1274 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode);
1275 Comment cmnt(masm_, var->IsContextSlot() 1275 Comment cmnt(masm_, var->IsContextSlot()
1276 ? "Context variable" 1276 ? "Context variable"
1277 : "Stack variable"); 1277 : "Stack variable");
1278 if (NeedsHoleCheckForLoad(proxy)) { 1278 if (proxy->needs_hole_check()) {
1279 // Throw a reference error when using an uninitialized let/const 1279 // Throw a reference error when using an uninitialized let/const
1280 // binding in harmony mode. 1280 // binding in harmony mode.
1281 Label done; 1281 Label done;
1282 GetVar(x0, var); 1282 GetVar(x0, var);
1283 __ JumpIfNotRoot(x0, Heap::kTheHoleValueRootIndex, &done); 1283 __ JumpIfNotRoot(x0, Heap::kTheHoleValueRootIndex, &done);
1284 __ Mov(x0, Operand(var->name())); 1284 __ Mov(x0, Operand(var->name()));
1285 __ Push(x0); 1285 __ Push(x0);
1286 __ CallRuntime(Runtime::kThrowReferenceError); 1286 __ CallRuntime(Runtime::kThrowReferenceError);
1287 __ Bind(&done); 1287 __ Bind(&done);
1288 context()->Plug(x0); 1288 context()->Plug(x0);
(...skipping 2410 matching lines...) Expand 10 before | Expand all | Expand 10 after
3699 } 3699 }
3700 3700
3701 return INTERRUPT; 3701 return INTERRUPT;
3702 } 3702 }
3703 3703
3704 3704
3705 } // namespace internal 3705 } // namespace internal
3706 } // namespace v8 3706 } // namespace v8
3707 3707
3708 #endif // V8_TARGET_ARCH_ARM64 3708 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/full-codegen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698