Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast/variables.h ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1269 matching lines...) Expand 10 before | Expand all | Expand 10 after
1280 context()->Plug(r0); 1280 context()->Plug(r0);
1281 break; 1281 break;
1282 } 1282 }
1283 1283
1284 case VariableLocation::PARAMETER: 1284 case VariableLocation::PARAMETER:
1285 case VariableLocation::LOCAL: 1285 case VariableLocation::LOCAL:
1286 case VariableLocation::CONTEXT: { 1286 case VariableLocation::CONTEXT: {
1287 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode); 1287 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode);
1288 Comment cmnt(masm_, var->IsContextSlot() ? "[ Context variable" 1288 Comment cmnt(masm_, var->IsContextSlot() ? "[ Context variable"
1289 : "[ Stack variable"); 1289 : "[ Stack variable");
1290 if (NeedsHoleCheckForLoad(proxy)) { 1290 if (proxy->needs_hole_check()) {
1291 // Throw a reference error when using an uninitialized let/const 1291 // Throw a reference error when using an uninitialized let/const
1292 // binding in harmony mode. 1292 // binding in harmony mode.
1293 Label done; 1293 Label done;
1294 GetVar(r0, var); 1294 GetVar(r0, var);
1295 __ CompareRoot(r0, Heap::kTheHoleValueRootIndex); 1295 __ CompareRoot(r0, Heap::kTheHoleValueRootIndex);
1296 __ b(ne, &done); 1296 __ b(ne, &done);
1297 __ mov(r0, Operand(var->name())); 1297 __ mov(r0, Operand(var->name()));
1298 __ push(r0); 1298 __ push(r0);
1299 __ CallRuntime(Runtime::kThrowReferenceError); 1299 __ CallRuntime(Runtime::kThrowReferenceError);
1300 __ bind(&done); 1300 __ bind(&done);
(...skipping 2392 matching lines...) Expand 10 before | Expand all | Expand 10 after
3693 DCHECK(interrupt_address == 3693 DCHECK(interrupt_address ==
3694 isolate->builtins()->OnStackReplacement()->entry()); 3694 isolate->builtins()->OnStackReplacement()->entry());
3695 return ON_STACK_REPLACEMENT; 3695 return ON_STACK_REPLACEMENT;
3696 } 3696 }
3697 3697
3698 3698
3699 } // namespace internal 3699 } // namespace internal
3700 } // namespace v8 3700 } // namespace v8
3701 3701
3702 #endif // V8_TARGET_ARCH_ARM 3702 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ast/variables.h ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698