Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: runtime/vm/raw_object.h

Issue 2411823003: VM support for running Kernel binaries. (Closed)
Patch Set: Address initial review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/raw_object.h
diff --git a/runtime/vm/raw_object.h b/runtime/vm/raw_object.h
index 984561693215044299677b81d4ae1d33908bba2f..f8c6ab02bec1abb2beaefb0540e3e7b4bc6f41b6 100644
--- a/runtime/vm/raw_object.h
+++ b/runtime/vm/raw_object.h
@@ -216,6 +216,10 @@ CLASS_LIST_TYPED_DATA(V)
#undef V
};
+enum {
+ kNoDilNode = 0
rmacnak 2016/10/13 00:56:39 NULL
Vyacheslav Egorov (Google) 2016/10/13 14:37:58 Good point. Done.
+};
+
#define SNAPSHOT_WRITER_SUPPORT() \
void WriteTo( \
SnapshotWriter* writer, intptr_t object_id, \
@@ -869,6 +873,7 @@ class RawFunction : public RawObject {
uint32_t kind_tag_; // See Function::KindTagBits.
int16_t num_fixed_parameters_;
int16_t num_optional_parameters_; // > 0: positional; < 0: named.
+ NOT_IN_PRECOMPILED(intptr_t dil_function_);
rmacnak 2016/10/13 00:56:39 void* ? I think it would make more sense to have
Kevin Millikin (Google) 2016/10/13 04:38:35 That's a good idea. We do have that. jenj@ is cu
Vyacheslav Egorov (Google) 2016/10/13 14:37:58 I made it void*. We can try to fold it into Scrip
NOT_IN_PRECOMPILED(uint16_t optimized_instruction_count_);
NOT_IN_PRECOMPILED(uint16_t optimized_call_site_count_);
NOT_IN_PRECOMPILED(int8_t deoptimization_counter_);
@@ -964,6 +969,7 @@ class RawField : public RawObject {
int8_t guarded_list_length_in_object_offset_;
uint8_t kind_bits_; // static, final, const, has initializer....
+ intptr_t dil_field_;
rmacnak 2016/10/13 00:56:39 void* ?
Vyacheslav Egorov (Google) 2016/10/13 14:37:58 Done. Also made it NOT_IN_PRECOMPILED.
friend class CidRewriteVisitor;
};

Powered by Google App Engine
This is Rietveld 408576698